From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 7/7] migration: do floating-point division
Date: Mon, 26 Jan 2015 12:12:27 +0100 [thread overview]
Message-ID: <1422270747-23994-8-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1422270747-23994-1-git-send-email-pbonzini@redhat.com>
Dividing integer expressions transferred_bytes and time_spent, and then converting
the integer quotient to type double. Any remainder, or fractional part of the
quotient, is ignored. Fix this.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index b3adbc6..6db75b8 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -646,7 +646,7 @@ static void *migration_thread(void *opaque)
if (current_time >= initial_time + BUFFER_DELAY) {
uint64_t transferred_bytes = qemu_ftell(s->file) - initial_bytes;
uint64_t time_spent = current_time - initial_time;
- double bandwidth = transferred_bytes / time_spent;
+ double bandwidth = (double)transferred_bytes / time_spent;
max_size = bandwidth * migrate_max_downtime() / 1000000;
s->mbps = time_spent ? (((double) transferred_bytes * 8.0) /
--
1.8.3.1
next prev parent reply other threads:[~2015-01-26 11:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 11:12 [Qemu-devel] [PATCH 0/7] Six coverity fixes and a cleanup Paolo Bonzini
2015-01-26 11:12 ` [Qemu-devel] [PATCH 1/7] cpu-exec: drop dead assignment Paolo Bonzini
2015-01-26 11:12 ` [Qemu-devel] [PATCH 2/7] cpu-exec: simplify icount code Paolo Bonzini
2015-01-26 11:12 ` [Qemu-devel] [PATCH 3/7] uri: avoid NULL arguments to strcmp Paolo Bonzini
2015-01-26 11:12 ` [Qemu-devel] [PATCH 4/7] qemu-sockets: improve error reporting in unix_listen_opts Paolo Bonzini
2015-01-26 11:12 ` [Qemu-devel] [PATCH 5/7] cutils: refine strtol error handling in parse_debug_env Paolo Bonzini
2015-02-07 8:52 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2015-01-26 11:12 ` [Qemu-devel] [PATCH 6/7] aes: remove a dead return statement Paolo Bonzini
2015-01-26 11:12 ` Paolo Bonzini [this message]
2015-01-26 18:06 ` [Qemu-devel] [PATCH 7/7] migration: do floating-point division Dr. David Alan Gilbert
2015-01-26 18:15 ` Juan Quintela
2015-02-07 9:00 ` [Qemu-devel] [Qemu-trivial] [PATCH 0/7] Six coverity fixes and a cleanup Michael Tokarev
2015-02-07 20:01 ` Paolo Bonzini
2015-02-07 20:39 ` Michael Tokarev
2015-02-09 12:17 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422270747-23994-8-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).