From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFhbD-00053j-Hs for qemu-devel@nongnu.org; Mon, 26 Jan 2015 06:13:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFhb4-0001nd-5r for qemu-devel@nongnu.org; Mon, 26 Jan 2015 06:12:55 -0500 Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 26 Jan 2015 12:12:27 +0100 Message-Id: <1422270747-23994-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1422270747-23994-1-git-send-email-pbonzini@redhat.com> References: <1422270747-23994-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 7/7] migration: do floating-point division List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, armbru@redhat.com Dividing integer expressions transferred_bytes and time_spent, and then converting the integer quotient to type double. Any remainder, or fractional part of the quotient, is ignored. Fix this. Signed-off-by: Paolo Bonzini --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index b3adbc6..6db75b8 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -646,7 +646,7 @@ static void *migration_thread(void *opaque) if (current_time >= initial_time + BUFFER_DELAY) { uint64_t transferred_bytes = qemu_ftell(s->file) - initial_bytes; uint64_t time_spent = current_time - initial_time; - double bandwidth = transferred_bytes / time_spent; + double bandwidth = (double)transferred_bytes / time_spent; max_size = bandwidth * migrate_max_downtime() / 1000000; s->mbps = time_spent ? (((double) transferred_bytes * 8.0) / -- 1.8.3.1