From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG9Tv-0002je-EP for qemu-devel@nongnu.org; Tue, 27 Jan 2015 11:59:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG99v-0002gG-3B for qemu-devel@nongnu.org; Tue, 27 Jan 2015 11:41:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG99u-0002g2-Pn for qemu-devel@nongnu.org; Tue, 27 Jan 2015 11:38:34 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RGcYUZ013724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 27 Jan 2015 11:38:34 -0500 From: Markus Armbruster Date: Tue, 27 Jan 2015 17:38:26 +0100 Message-Id: <1422376711-31648-2-git-send-email-armbru@redhat.com> In-Reply-To: <1422376711-31648-1-git-send-email-armbru@redhat.com> References: <1422376711-31648-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 1/6] onenand: g_malloc() can't fail, bury dead error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@redhat.com Signed-off-by: Markus Armbruster --- hw/block/onenand.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/block/onenand.c b/hw/block/onenand.c index 348630d..1b2c893 100644 --- a/hw/block/onenand.c +++ b/hw/block/onenand.c @@ -346,15 +346,9 @@ static inline int onenand_prog_spare(OneNANDState *s, int sec, int secn, static inline int onenand_erase(OneNANDState *s, int sec, int num) { uint8_t *blankbuf, *tmpbuf; + blankbuf = g_malloc(512); - if (!blankbuf) { - return 1; - } tmpbuf = g_malloc(512); - if (!tmpbuf) { - g_free(blankbuf); - return 1; - } memset(blankbuf, 0xff, 512); for (; num > 0; num--, sec++) { if (s->blk_cur) { -- 1.9.3