qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, agraf@suse.de,
	Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 1/9] s390: Plug memory leak on s390_pci_generate_event() error path
Date: Wed, 28 Jan 2015 15:31:30 +0100	[thread overview]
Message-ID: <1422455498-889-2-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1422455498-889-1-git-send-email-cornelia.huck@de.ibm.com>

From: Markus Armbruster <armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 hw/s390x/s390-pci-bus.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 1201b8d..d25ac74 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -187,7 +187,7 @@ S390PCIBusDevice *s390_pci_find_dev_by_fh(uint32_t fh)
 static void s390_pci_generate_event(uint8_t cc, uint16_t pec, uint32_t fh,
                                     uint32_t fid, uint64_t faddr, uint32_t e)
 {
-    SeiContainer *sei_cont = g_malloc0(sizeof(SeiContainer));
+    SeiContainer *sei_cont;
     S390pciState *s = S390_PCI_HOST_BRIDGE(
         object_resolve_path(TYPE_S390_PCI_HOST_BRIDGE, NULL));
 
@@ -195,6 +195,7 @@ static void s390_pci_generate_event(uint8_t cc, uint16_t pec, uint32_t fh,
         return;
     }
 
+    sei_cont = g_malloc0(sizeof(SeiContainer));
     sei_cont->fh = fh;
     sei_cont->fid = fid;
     sei_cont->cc = cc;
-- 
1.7.9.5

  reply	other threads:[~2015-01-28 14:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 14:31 [Qemu-devel] [PATCH 0/9] s390x bugfixes and cleanup Cornelia Huck
2015-01-28 14:31 ` Cornelia Huck [this message]
2015-01-28 14:31 ` [Qemu-devel] [PATCH 2/9] s390x/pci: avoid sign extension in stpcifc Cornelia Huck
2015-01-28 14:31 ` [Qemu-devel] [PATCH 3/9] s390x/pci: check for invalid function handle Cornelia Huck
2015-01-28 14:31 ` [Qemu-devel] [PATCH 4/9] s390x/pci: fix dma notifications in rpcit instruction Cornelia Huck
2015-01-28 14:31 ` [Qemu-devel] [PATCH 5/9] s390x/kvm: Fix diag-308 register decoding Cornelia Huck
2015-01-28 14:31 ` [Qemu-devel] [PATCH 6/9] s390x/kvm: unknown DIAGNOSE code should give a specification exception Cornelia Huck
2015-01-28 14:31 ` [Qemu-devel] [PATCH 7/9] s390x/ipl: Improved code indentation in s390_ipl_init() Cornelia Huck
2015-01-28 14:31 ` [Qemu-devel] [PATCH 8/9] pc-bios/s390-ccw: fix sparse warnings Cornelia Huck
2015-01-28 14:31 ` [Qemu-devel] [PATCH 9/9] pc-bios/s390-ccw: update binary Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422455498-889-2-git-send-email-cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=armbru@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).