From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGTht-0000Fu-Ji for qemu-devel@nongnu.org; Wed, 28 Jan 2015 09:35:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGThq-0006jo-Dg for qemu-devel@nongnu.org; Wed, 28 Jan 2015 09:35:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGThq-0006jj-6F for qemu-devel@nongnu.org; Wed, 28 Jan 2015 09:34:58 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SEYvuP020505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 09:34:57 -0500 From: Igor Mammedov Date: Wed, 28 Jan 2015 14:34:46 +0000 Message-Id: <1422455690-13950-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1422455690-13950-1-git-send-email-imammedo@redhat.com> References: <1422455690-13950-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH v6 1/5] pc: acpi-build: cleanup AcpiPmInfo initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com zero initialize AcpiPmInfo struct to reduce code bloat a little bit. Signed-off-by: Igor Mammedov Reviewed-by: Claudio Fontana Reviewed-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 4944249..6f8d4e3 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -172,6 +172,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) Object *obj = NULL; QObject *o; + memset(pm, 0, sizeof(*pm)); + if (piix) { obj = piix; } @@ -184,22 +186,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL); if (o) { pm->s3_disabled = qint_get_int(qobject_to_qint(o)); - } else { - pm->s3_disabled = false; } qobject_decref(o); o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL); if (o) { pm->s4_disabled = qint_get_int(qobject_to_qint(o)); - } else { - pm->s4_disabled = false; } qobject_decref(o); o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL); if (o) { pm->s4_val = qint_get_int(qobject_to_qint(o)); - } else { - pm->s4_val = false; } qobject_decref(o); -- 1.8.3.1