From: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [-prfix=PATCH v2 RFC 2/6] qemu-iotests: qemu machine type support
Date: Thu, 29 Jan 2015 13:58:34 +0800 [thread overview]
Message-ID: <1422511118-13049-3-git-send-email-chenxg@linux.vnet.ibm.com> (raw)
In-Reply-To: <1422511118-13049-1-git-send-email-chenxg@linux.vnet.ibm.com>
From: Mao Chuan Li <maochuan@linux.vnet.ibm.com>
This patch adds qemu machine type support to the io test suite. Based on
the qemu default machine type the reference output file can now vary
from the default to a machine specific output file if necessary. That
shall allow all platforms to use this test suite.
Reviewed-by: Michael Mueller <mimu@linux.vnet.ibm.com>
Signed-off-by: Mao Chuan Li <maochuan@linux.vnet.ibm.com>
---
tests/qemu-iotests/check | 5 +++++
tests/qemu-iotests/common.config | 1 +
tests/qemu-iotests/iotests.py | 1 +
3 files changed, 7 insertions(+)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 8ca4011..fc0351d 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -323,6 +323,11 @@ do
fi
reference="$source_iotests/$seq.out"
+ reference_machine="$source_iotests/$seq.$QEMU_DEFAULT_MACHINE.out"
+ if [ -f $reference_machine ]; then
+ reference=$reference_machine
+ fi
+
if [ "$CACHEMODE" = "none" ]; then
[ -f "$source_iotests/$seq.out.nocache" ] && reference="$source_iotests/$seq.out.nocache"
fi
diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config
index bd6790b..73e25da 100644
--- a/tests/qemu-iotests/common.config
+++ b/tests/qemu-iotests/common.config
@@ -107,6 +107,7 @@ export QEMU=$QEMU_PROG
export QEMU_IMG=$QEMU_IMG_PROG
export QEMU_IO="$QEMU_IO_PROG $QEMU_IO_OPTIONS"
export QEMU_NBD=$QEMU_NBD_PROG
+export QEMU_DEFAULT_MACHINE=$($QEMU -machine ? | awk '/(default)/{print $1}')
[ -f /etc/qemu-iotest.config ] && . /etc/qemu-iotest.config
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index f57f154..69dee95 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -39,6 +39,7 @@ imgproto = os.environ.get('IMGPROTO', 'file')
test_dir = os.environ.get('TEST_DIR', '/var/tmp')
output_dir = os.environ.get('OUTPUT_DIR', '.')
cachemode = os.environ.get('CACHEMODE')
+qemu_default_machine = os.environ.get('QEMU_DEFAULT_MACHINE')
socket_scm_helper = os.environ.get('SOCKET_SCM_HELPER', 'socket_scm_helper')
--
1.9.1
next prev parent reply other threads:[~2015-01-29 5:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 5:58 [Qemu-devel] [-prfix=PATCH v2 RFC 0/6] Update tests/qemu-iotests failing cases for the s390 platform Xiao Guang Chen
2015-01-29 5:58 ` [Qemu-devel] [-prfix=PATCH v2 RFC 1/6] qemu-iotests: fix tests 067, 071 and 087 Xiao Guang Chen
2015-01-29 5:58 ` Xiao Guang Chen [this message]
2015-01-29 5:58 ` [Qemu-devel] [-prfix=PATCH v2 RFC 3/6] qemu-iotests: run qemu with -nodefaults Xiao Guang Chen
2015-01-29 5:58 ` [Qemu-devel] [-prfix=PATCH v2 RFC 4/6] qemu-iotests: s390x: fix test 041 Xiao Guang Chen
2015-01-29 5:58 ` [Qemu-devel] [-prfix=PATCH v2 RFC 5/6] qemu-iotests: s390x: fix test 051 Xiao Guang Chen
2015-01-29 5:58 ` [Qemu-devel] [-prfix=PATCH v2 RFC 6/6] qemu-iotests: s390x: fix test 055 Xiao Guang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422511118-13049-3-git-send-email-chenxg@linux.vnet.ibm.com \
--to=chenxg@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).