qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Subject: [Qemu-devel] [PULL 05/11] memory: remove assertion on memory_region_destroy
Date: Fri, 30 Jan 2015 16:01:12 +0100	[thread overview]
Message-ID: <1422630078-18704-6-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1422630078-18704-1-git-send-email-pbonzini@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

Now that memory_region_destroy can be called from an RCU callback,
checking the BQL-protected global memory_region_transaction_depth
does not make much sense.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 memory.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/memory.c b/memory.c
index c343bf3..8c3d8c0 100644
--- a/memory.c
+++ b/memory.c
@@ -1263,7 +1263,6 @@ static void memory_region_finalize(Object *obj)
     MemoryRegion *mr = MEMORY_REGION(obj);
 
     assert(QTAILQ_EMPTY(&mr->subregions));
-    assert(memory_region_transaction_depth == 0);
     mr->destructor(mr);
     memory_region_clear_coalescing(mr);
     g_free((char *)mr->name);
-- 
1.8.3.1

  parent reply	other threads:[~2015-01-30 15:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 15:01 [Qemu-devel] [PULL 00/11] RCU, scsi, modules, icount changes for 2015-01-30 Paolo Bonzini
2015-01-30 15:01 ` [Qemu-devel] [PULL 01/11] rcu: add rcu library Paolo Bonzini
2015-01-30 15:01 ` [Qemu-devel] [PULL 02/11] rcu: add rcutorture Paolo Bonzini
2015-01-30 15:01 ` [Qemu-devel] [PULL 03/11] rcu: allow nesting of rcu_read_lock/rcu_read_unlock Paolo Bonzini
2015-01-30 15:01 ` [Qemu-devel] [PULL 04/11] rcu: add call_rcu Paolo Bonzini
2015-01-30 15:01 ` Paolo Bonzini [this message]
2015-01-30 15:01 ` [Qemu-devel] [PULL 06/11] memory: protect current_map by RCU Paolo Bonzini
2015-01-30 15:01 ` [Qemu-devel] [PULL 07/11] memory: avoid ref/unref in memory_region_find Paolo Bonzini
2015-01-30 15:01 ` [Qemu-devel] [PULL 08/11] cpu-exec: simplify align_clocks Paolo Bonzini
2015-01-30 15:01 ` [Qemu-devel] [PULL 09/11] cpu-exec: simplify init_delay_params Paolo Bonzini
2015-01-30 15:01 ` [Qemu-devel] [PULL 10/11] scsi: Fix scsi_req_cancel_async for no aiocb req Paolo Bonzini
2015-01-30 15:01 ` [Qemu-devel] [PULL 11/11] configure: Default to enable module build Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2015-01-30 15:19 [Qemu-devel] [PULL 00/11] RCU, scsi, modules, icount changes for 2015-01-30 Paolo Bonzini
2015-01-30 15:19 ` [Qemu-devel] [PULL 05/11] memory: remove assertion on memory_region_destroy Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422630078-18704-6-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).