From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIErh-0004eO-Uu for qemu-devel@nongnu.org; Mon, 02 Feb 2015 06:08:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIErc-00037t-WF for qemu-devel@nongnu.org; Mon, 02 Feb 2015 06:08:25 -0500 Received: from smtp.citrix.com ([66.165.176.89]:49880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIErc-00037b-Rf for qemu-devel@nongnu.org; Mon, 02 Feb 2015 06:08:20 -0500 Message-ID: <1422875296.10090.0.camel@citrix.com> From: Ian Campbell Date: Mon, 2 Feb 2015 11:08:16 +0000 In-Reply-To: <1422839843-25622-1-git-send-email-tiejun.chen@intel.com> References: <1422839843-25622-1-git-send-email-tiejun.chen@intel.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tiejun Chen Cc: wei.liu2@citrix.com, Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, kraxel@redhat.com On Mon, 2015-02-02 at 09:17 +0800, Tiejun Chen wrote: > When we're working to support IGD GFX passthrough with qemu > upstream, instead of "-gfx_passthru" we'd like to make that > a machine option, "-machine xxx,-igd-passthru=on". This need > to bring a change on tool side. >>From which Qemu version is this new option accepted? What will a verison of qemu prior to then do when presented with the new option? (nb: you have an extra '-' in the description I think) > > Signed-off-by: Tiejun Chen > --- > v2: > > * Based on some discussions with Wei we'd like to keep both old > option, -gfx_passthru, and new machine property option, > "-machine xxx,-igd-passthru=on" at the same time but deprecate > the old one. Then finally we remove the old one at that point > that to give downstream (in this case, Xen) time to cope with the > change. > > tools/libxl/libxl_dm.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index c2b0487..8405f0b 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -701,6 +701,11 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, > flexarray_append(dm_args, "-net"); > flexarray_append(dm_args, "none"); > } > + /* > + * Although we already introduce 'igd-passthru', but we'd like > + * to remove this until we give downstream time to cope with > + * the change. > + */ > if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { > flexarray_append(dm_args, "-gfx_passthru"); > } > @@ -748,6 +753,11 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, > machinearg, max_ram_below_4g); > } > } > + > + if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { > + machinearg = libxl__sprintf(gc, "%s,igd-passthru=on", machinearg); > + } > + > flexarray_append(dm_args, machinearg); > for (i = 0; b_info->extra_hvm && b_info->extra_hvm[i] != NULL; i++) > flexarray_append(dm_args, b_info->extra_hvm[i]);