From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YINQ9-00019O-Vu for qemu-devel@nongnu.org; Mon, 02 Feb 2015 15:16:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YINQ5-0001CD-8S for qemu-devel@nongnu.org; Mon, 02 Feb 2015 15:16:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YINQ4-0001Bu-RC for qemu-devel@nongnu.org; Mon, 02 Feb 2015 15:16:29 -0500 Message-ID: <1422908182.22865.421.camel@redhat.com> From: Alex Williamson Date: Mon, 02 Feb 2015 13:16:22 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 4/8] vfio-pci: pass the aer error to guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan Cc: marcel@redhat.com, izumi.taku@jp.fujitsu.com, qemu-devel@nongnu.org On Wed, 2015-01-28 at 16:37 +0800, Chen Fan wrote: > when the vfio device encounters an uncorrectable error in host, > the vfio_pci driver will signal the eventfd registered by this > vfio device, the results in the qemu eventfd handler getting > invoked. > > this patch is to pass the error to guest and have the guest driver > recover from the error. > > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 34 ++++++++++++++++++++++++++++------ > 1 file changed, 28 insertions(+), 6 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 2072261..8c81bb3 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3141,18 +3141,40 @@ static void vfio_put_device(VFIOPCIDevice *vdev) > static void vfio_err_notifier_handler(void *opaque) > { > VFIOPCIDevice *vdev = opaque; > + PCIDevice *dev = &vdev->pdev; > + PCIEAERMsg msg = { > + .severity = 0, > + .source_id = (pci_bus_num(dev->bus) << 8) | dev->devfn, > + }; > > if (!event_notifier_test_and_clear(&vdev->err_notifier)) { > return; > } > > + /* we should read the error details from the real hardware > + * configuration spaces, here we only need to do is signaling > + * to guest an uncorrectable error has occurred. > + */ > + if (dev->exp.aer_cap) { > + uint8_t *aer_cap = dev->config + dev->exp.aer_cap; > + uint32_t uncor_status; > + bool isfatal; > + > + uncor_status = vfio_pci_read_config(dev, > + dev->exp.aer_cap + PCI_ERR_UNCOR_STATUS, 4); > + > + isfatal = uncor_status & pci_get_long(aer_cap + PCI_ERR_UNCOR_SEVER); > + > + msg.severity = isfatal ? PCI_ERR_ROOT_CMD_FATAL_EN : > + PCI_ERR_ROOT_CMD_NONFATAL_EN; > + > + pcie_aer_msg(dev, &msg); > + return; > + } What if the guest machine type is 440FX? We've just killed the existing vm_stop functionality for the majority of users. > + > /* > - * TBD. Retrieve the error details and decide what action > - * needs to be taken. One of the actions could be to pass > - * the error to the guest and have the guest driver recover > - * from the error. This requires that PCIe capabilities be > - * exposed to the guest. For now, we just terminate the > - * guest to contain the error. > + * If the aer capability is not exposed to the guest. we just > + * terminate the guest to contain the error. Just because it's exposed doesn't mean the guest chipset allows access to it, right? > */ > > error_report("%s(%04x:%02x:%02x.%x) Unrecoverable error detected. "