qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	patches@linaro.org
Subject: [Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros
Date: Mon,  2 Feb 2015 20:31:33 +0000	[thread overview]
Message-ID: <1422909096-32268-1-git-send-email-peter.maydell@linaro.org> (raw)

This patchset expands out all the uses of the softfloat STATUS_VAR,
STATUS_PARAM and STATUS macros and removes their definitions.

In my opinion these macros are basically just obfuscating the
passing around and use of a float_status pointer in the softfloat
code, and serve no useful purpose. I used to think that we should
retain them on the offchance we wanted to pull in new softfloat
upstream code, but this is wrong on three counts now:
 (1) there's never been any new softfloat upstream code to take
 (2) even if there were, we couldn't take it because of the license
 (3) these macros aren't even in the upstream version; they were
     added by Fabrice when he integrated softfloat into QEMU

We've never used whatever flexibility might in theory be
permitted by the indirection through this set of macros, so
this patchset just deletes them all.

The changes make an alarmingly large diffstat, but it's just
mechanical expansion plus fixing of coding style issues on the
affected lines. (Lots of style fixing because the softfloat
upstream coding is (a) a long way away from QEMU's and (b) bonkers.)

This obviously is likely to induce merge conflicts with any
other in-flight softfloat changes, for which I apologise in
advance.

[Next on the cleanup list: get rid of those 'int8/int32/int64'
types...]

Peter Maydell (3):
  softfloat: Expand out the STATUS_PARAM macro
  softfloat: expand out STATUS_VAR
  softfloat: expand out STATUS macro

 fpu/softfloat-specialize.h |  124 ++--
 fpu/softfloat.c            | 1609 ++++++++++++++++++++++++--------------------
 include/fpu/softfloat.h    |  371 +++++-----
 target-mips/msa_helper.c   |   74 +-
 4 files changed, 1188 insertions(+), 990 deletions(-)

-- 
1.9.1

             reply	other threads:[~2015-02-02 20:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 20:31 Peter Maydell [this message]
2015-02-02 20:31 ` [Qemu-devel] [PATCH 1/3] softfloat: Expand out the STATUS_PARAM macro Peter Maydell
2015-02-02 21:37   ` Richard Henderson
2015-02-03 11:28     ` Peter Maydell
2015-02-02 20:31 ` [Qemu-devel] [PATCH 2/3] softfloat: expand out STATUS_VAR Peter Maydell
2015-02-02 20:31 ` [Qemu-devel] [PATCH 3/3] softfloat: expand out STATUS macro Peter Maydell
2015-02-02 21:37 ` [Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros Richard Henderson
2015-02-06 15:47   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422909096-32268-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=macro@linux-mips.org \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).