qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros
@ 2015-02-02 20:31 Peter Maydell
  2015-02-02 20:31 ` [Qemu-devel] [PATCH 1/3] softfloat: Expand out the STATUS_PARAM macro Peter Maydell
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Peter Maydell @ 2015-02-02 20:31 UTC (permalink / raw)
  To: qemu-devel; +Cc: Richard Henderson, Maciej W. Rozycki, patches

This patchset expands out all the uses of the softfloat STATUS_VAR,
STATUS_PARAM and STATUS macros and removes their definitions.

In my opinion these macros are basically just obfuscating the
passing around and use of a float_status pointer in the softfloat
code, and serve no useful purpose. I used to think that we should
retain them on the offchance we wanted to pull in new softfloat
upstream code, but this is wrong on three counts now:
 (1) there's never been any new softfloat upstream code to take
 (2) even if there were, we couldn't take it because of the license
 (3) these macros aren't even in the upstream version; they were
     added by Fabrice when he integrated softfloat into QEMU

We've never used whatever flexibility might in theory be
permitted by the indirection through this set of macros, so
this patchset just deletes them all.

The changes make an alarmingly large diffstat, but it's just
mechanical expansion plus fixing of coding style issues on the
affected lines. (Lots of style fixing because the softfloat
upstream coding is (a) a long way away from QEMU's and (b) bonkers.)

This obviously is likely to induce merge conflicts with any
other in-flight softfloat changes, for which I apologise in
advance.

[Next on the cleanup list: get rid of those 'int8/int32/int64'
types...]

Peter Maydell (3):
  softfloat: Expand out the STATUS_PARAM macro
  softfloat: expand out STATUS_VAR
  softfloat: expand out STATUS macro

 fpu/softfloat-specialize.h |  124 ++--
 fpu/softfloat.c            | 1609 ++++++++++++++++++++++++--------------------
 include/fpu/softfloat.h    |  371 +++++-----
 target-mips/msa_helper.c   |   74 +-
 4 files changed, 1188 insertions(+), 990 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-02-06 15:48 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-02 20:31 [Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros Peter Maydell
2015-02-02 20:31 ` [Qemu-devel] [PATCH 1/3] softfloat: Expand out the STATUS_PARAM macro Peter Maydell
2015-02-02 21:37   ` Richard Henderson
2015-02-03 11:28     ` Peter Maydell
2015-02-02 20:31 ` [Qemu-devel] [PATCH 2/3] softfloat: expand out STATUS_VAR Peter Maydell
2015-02-02 20:31 ` [Qemu-devel] [PATCH 3/3] softfloat: expand out STATUS macro Peter Maydell
2015-02-02 21:37 ` [Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros Richard Henderson
2015-02-06 15:47   ` Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).