From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: peter.maydell@linaro.org
Cc: Frank Blaschka <blaschka@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com,
jfrei@linux.vnet.ibm.com,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: [Qemu-devel] [PULL 3/9] s390x/pci: check for invalid function handle
Date: Tue, 3 Feb 2015 14:08:42 +0100 [thread overview]
Message-ID: <1422968928-9710-4-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1422968928-9710-1-git-send-email-cornelia.huck@de.ibm.com>
From: Frank Blaschka <blaschka@linux.vnet.ibm.com>
broken guest may provide 0 (invalid) function handle to zpci
instructions. Since we use function handle 0 to indicate an empty
slot in the PHB we have to add an additional check to spot this
kind of error.
Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/s390x/s390-pci-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index d25ac74..dc455a2 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -170,7 +170,7 @@ S390PCIBusDevice *s390_pci_find_dev_by_fh(uint32_t fh)
S390pciState *s = S390_PCI_HOST_BRIDGE(
object_resolve_path(TYPE_S390_PCI_HOST_BRIDGE, NULL));
- if (!s) {
+ if (!s || !fh) {
return NULL;
}
--
1.7.9.5
next prev parent reply other threads:[~2015-02-03 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 13:08 [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups Cornelia Huck
2015-02-03 13:08 ` [Qemu-devel] [PULL 1/9] s390: Plug memory leak on s390_pci_generate_event() error path Cornelia Huck
2015-02-03 13:08 ` [Qemu-devel] [PULL 2/9] s390x/pci: avoid sign extension in stpcifc Cornelia Huck
2015-02-03 13:08 ` Cornelia Huck [this message]
2015-02-03 13:08 ` [Qemu-devel] [PULL 4/9] s390x/pci: fix dma notifications in rpcit instruction Cornelia Huck
2015-02-03 13:08 ` [Qemu-devel] [PULL 5/9] s390x/kvm: Fix diag-308 register decoding Cornelia Huck
2015-02-03 13:08 ` [Qemu-devel] [PULL 6/9] s390x/kvm: unknown DIAGNOSE code should give a specification exception Cornelia Huck
2015-02-03 13:08 ` [Qemu-devel] [PULL 7/9] s390x/ipl: Improved code indentation in s390_ipl_init() Cornelia Huck
2015-02-03 13:08 ` [Qemu-devel] [PULL 8/9] pc-bios/s390-ccw: fix sparse warnings Cornelia Huck
2015-02-03 13:08 ` [Qemu-devel] [PULL 9/9] pc-bios/s390-ccw: update binary Cornelia Huck
2015-02-03 13:45 ` [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups Peter Maydell
2015-02-03 13:48 ` Christian Borntraeger
2015-02-03 14:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422968928-9710-4-git-send-email-cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=blaschka@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).