From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: kbastian@mail.uni-paderborn.de, peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 07/10] target-s390x: Mark check_privileged() as !CONFIG_USER_ONLY
Date: Tue, 3 Feb 2015 12:42:58 -0800 [thread overview]
Message-ID: <1422996181-22383-8-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1422996181-22383-1-git-send-email-rth@twiddle.net>
From: Peter Maydell <peter.maydell@linaro.org>
The function check_privileged() is only used in the softmmu configs;
wrap it in an #ifndef CONFIG_USER_ONLY to avoid clang warnings on the
linux-user builds.
[rth: Remove inline marker too; it was only there to prevent exactly
this warning in GCC.]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Message-id: 1419373100-17690-2-git-send-email-peter.maydell@linaro.org
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
target-s390x/translate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target-s390x/translate.c b/target-s390x/translate.c
index e7a6c1d..8b36eca 100644
--- a/target-s390x/translate.c
+++ b/target-s390x/translate.c
@@ -317,12 +317,14 @@ static inline void gen_illegal_opcode(DisasContext *s)
gen_program_exception(s, PGM_SPECIFICATION);
}
-static inline void check_privileged(DisasContext *s)
+#ifndef CONFIG_USER_ONLY
+static void check_privileged(DisasContext *s)
{
if (s->tb->flags & (PSW_MASK_PSTATE >> 32)) {
gen_program_exception(s, PGM_PRIVILEGED);
}
}
+#endif
static TCGv_i64 get_address(DisasContext *s, int x2, int b2, int d2)
{
--
2.1.0
next prev parent reply other threads:[~2015-02-03 20:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 20:42 [Qemu-devel] [PULL 00/10] s390x translator bug fixes Richard Henderson
2015-02-03 20:42 ` [Qemu-devel] [PULL 01/10] target-s390: Implement SAM specification exception Richard Henderson
2015-02-03 20:42 ` [Qemu-devel] [PULL 02/10] target-s390: Implement EPSW Richard Henderson
2015-02-03 20:42 ` [Qemu-devel] [PULL 03/10] target-s390: Fix STIDP Richard Henderson
2015-02-03 20:42 ` [Qemu-devel] [PULL 04/10] target-s390: Fix STURA Richard Henderson
2015-02-03 20:42 ` [Qemu-devel] [PULL 05/10] target-s390: Implement LURA, LURAG, STURG Richard Henderson
2015-02-03 20:42 ` [Qemu-devel] [PULL 06/10] target-s390: Implement ECAG Richard Henderson
2015-02-03 20:42 ` Richard Henderson [this message]
2015-02-03 20:42 ` [Qemu-devel] [PULL 08/10] disas/s390.c: Remove unused variables Richard Henderson
2015-02-03 20:43 ` [Qemu-devel] [PULL 09/10] target-s390x: support OC and NC in the EX instruction Richard Henderson
2015-02-03 20:43 ` [Qemu-devel] [PULL 10/10] target-s390x: fix and optimize slb* and slbg* computation of carry/borrow flag Richard Henderson
2015-02-03 22:33 ` [Qemu-devel] [PULL 00/10] s390x translator bug fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422996181-22383-8-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).