From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIxA3-0007Ul-PZ for qemu-devel@nongnu.org; Wed, 04 Feb 2015 05:26:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIxA0-0003UM-5K for qemu-devel@nongnu.org; Wed, 04 Feb 2015 05:26:19 -0500 From: Markus Armbruster Date: Wed, 4 Feb 2015 11:26:03 +0100 Message-Id: <1423045567-29855-3-git-send-email-armbru@redhat.com> In-Reply-To: <1423045567-29855-1-git-send-email-armbru@redhat.com> References: <1423045567-29855-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/6] rtl8139: g_malloc() can't fail, bury dead error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, arei.gonglei@huawei.com, thuth@linux.vnet.ibm.com Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Gonglei --- hw/net/rtl8139.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 6fa9e0a..b55e438 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -2075,20 +2075,6 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) "length to %d\n", txsize); } - if (!s->cplus_txbuffer) - { - /* out of memory */ - - DPRINTF("+++ C+ mode transmiter failed to reallocate %d bytes\n", - s->cplus_txbuffer_len); - - /* update tally counter */ - ++s->tally_counters.TxERR; - ++s->tally_counters.TxAbt; - - return 0; - } - /* append more data to the packet */ DPRINTF("+++ C+ mode transmit reading %d bytes from host memory at " -- 1.9.3