From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was selected in command line
Date: Wed, 4 Feb 2015 13:25:58 +0200 [thread overview]
Message-ID: <1423049158-20483-1-git-send-email-marcel@redhat.com> (raw)
Commit 4db14629c3 (vnc: switch to QemuOpts, allow multiple servers)
converted vnc option to QemuOpts.
However, the default vnc display had ...,to=99,... between parameters
that is not covered by the QemuOpts.
Remove it because is not longer used and solves the crash.
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
This issue is bugging me some time now. Please let me know if
I got it wrong.
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 983259b..c8f33d2 100644
--- a/vl.c
+++ b/vl.c
@@ -3970,7 +3970,7 @@ int main(int argc, char **argv, char **envp)
#elif defined(CONFIG_SDL) || defined(CONFIG_COCOA)
display_type = DT_SDL;
#elif defined(CONFIG_VNC)
- vnc_parse_func("localhost:0,to=99,id=default");
+ vnc_parse_func("localhost:0,id=default");
show_vnc_port = 1;
#else
display_type = DT_NONE;
--
2.1.0
next reply other threads:[~2015-02-04 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 11:25 Marcel Apfelbaum [this message]
2015-02-04 20:40 ` [Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was selected in command line Don Slutz
2015-02-04 21:00 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423049158-20483-1-git-send-email-marcel@redhat.com \
--to=marcel@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).