From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIyEw-0001yL-2g for qemu-devel@nongnu.org; Wed, 04 Feb 2015 06:35:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIyEs-0003Uu-Mg for qemu-devel@nongnu.org; Wed, 04 Feb 2015 06:35:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIy5q-0008N3-U9 for qemu-devel@nongnu.org; Wed, 04 Feb 2015 06:26:03 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t14BQ0mN021848 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 4 Feb 2015 06:26:00 -0500 From: Marcel Apfelbaum Date: Wed, 4 Feb 2015 13:25:58 +0200 Message-Id: <1423049158-20483-1-git-send-email-marcel@redhat.com> Subject: [Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was selected in command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, kraxel@redhat.com Commit 4db14629c3 (vnc: switch to QemuOpts, allow multiple servers) converted vnc option to QemuOpts. However, the default vnc display had ...,to=99,... between parameters that is not covered by the QemuOpts. Remove it because is not longer used and solves the crash. Signed-off-by: Marcel Apfelbaum --- This issue is bugging me some time now. Please let me know if I got it wrong. vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 983259b..c8f33d2 100644 --- a/vl.c +++ b/vl.c @@ -3970,7 +3970,7 @@ int main(int argc, char **argv, char **envp) #elif defined(CONFIG_SDL) || defined(CONFIG_COCOA) display_type = DT_SDL; #elif defined(CONFIG_VNC) - vnc_parse_func("localhost:0,to=99,id=default"); + vnc_parse_func("localhost:0,id=default"); show_vnc_port = 1; #else display_type = DT_NONE; -- 2.1.0