qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH 3/7] usb: Do not prefix error_setg() messages with "Error: "
Date: Wed,  4 Feb 2015 13:28:10 +0100	[thread overview]
Message-ID: <1423052894-13125-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1423052894-13125-1-git-send-email-armbru@redhat.com>

Because it produces beauties like

    (qemu) usb_add mouse
    Failed to initialize USB device 'usb-mouse': Error: tried to attach usb device QEMU USB Mouse to a bus with no free ports

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/usb/bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 3f69fe1..3e85afe 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -412,7 +412,7 @@ void usb_claim_port(USBDevice *dev, Error **errp)
             }
         }
         if (port == NULL) {
-            error_setg(errp, "Error: usb port %s (bus %s) not found (in use?)",
+            error_setg(errp, "usb port %s (bus %s) not found (in use?)",
                        dev->port_path, bus->qbus.name);
             return;
         }
@@ -422,7 +422,7 @@ void usb_claim_port(USBDevice *dev, Error **errp)
             usb_create_simple(bus, "usb-hub");
         }
         if (bus->nfree == 0) {
-            error_setg(errp, "Error: tried to attach usb device %s to a bus "
+            error_setg(errp, "tried to attach usb device %s to a bus "
                        "with no free ports", dev->product_desc);
             return;
         }
-- 
1.9.3

  parent reply	other threads:[~2015-02-04 12:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 12:28 [Qemu-devel] [PATCH 0/7] usb: Improvements around device realization Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 1/7] usb: usb_create() can't fail, drop useless error handling Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 2/7] usb: Improve -usbdevice error reporting a bit Markus Armbruster
2015-02-04 12:28 ` Markus Armbruster [this message]
2015-02-04 12:28 ` [Qemu-devel] [PATCH 4/7] usb: Suppress bogus error when automatic usb-hub creation fails Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 5/7] usb: Change usb_create_simple() to abort on failure Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 6/7] r2d: Don't use legacy -usbdevice support for setting up board Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 7/7] PPC: " Markus Armbruster
2015-02-04 12:40   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423052894-13125-4-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=afaerber@suse.de \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).