From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH 5/7] usb: Change usb_create_simple() to abort on failure
Date: Wed, 4 Feb 2015 13:28:12 +0100 [thread overview]
Message-ID: <1423052894-13125-6-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1423052894-13125-1-git-send-email-armbru@redhat.com>
Instead of returning null pointer. Matches pci_create_simple(),
isa_create_simple(), sysbus_create_simple(). It's unused since the
previous commit, but I'll put it to use again shortly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/usb/bus.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 5abfac0..d83a938 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -339,14 +339,7 @@ static USBDevice *usb_try_create_simple(USBBus *bus, const char *name,
USBDevice *usb_create_simple(USBBus *bus, const char *name)
{
- Error *err = NULL;
- USBDevice *dev = usb_try_create_simple(bus, name, &err);
-
- if (!dev) {
- error_report("%s", error_get_pretty(err));
- error_free(err);
- }
- return dev;
+ return usb_try_create_simple(bus, name, &error_abort);
}
static void usb_fill_port(USBPort *port, void *opaque, int index,
--
1.9.3
next prev parent reply other threads:[~2015-02-04 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 12:28 [Qemu-devel] [PATCH 0/7] usb: Improvements around device realization Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 1/7] usb: usb_create() can't fail, drop useless error handling Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 2/7] usb: Improve -usbdevice error reporting a bit Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 3/7] usb: Do not prefix error_setg() messages with "Error: " Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 4/7] usb: Suppress bogus error when automatic usb-hub creation fails Markus Armbruster
2015-02-04 12:28 ` Markus Armbruster [this message]
2015-02-04 12:28 ` [Qemu-devel] [PATCH 6/7] r2d: Don't use legacy -usbdevice support for setting up board Markus Armbruster
2015-02-04 12:28 ` [Qemu-devel] [PATCH 7/7] PPC: " Markus Armbruster
2015-02-04 12:40 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423052894-13125-6-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).