From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIz4D-00065P-63 for qemu-devel@nongnu.org; Wed, 04 Feb 2015 07:28:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIz47-00086D-Ak for qemu-devel@nongnu.org; Wed, 04 Feb 2015 07:28:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIz47-000866-3R for qemu-devel@nongnu.org; Wed, 04 Feb 2015 07:28:19 -0500 From: Markus Armbruster Date: Wed, 4 Feb 2015 13:28:12 +0100 Message-Id: <1423052894-13125-6-git-send-email-armbru@redhat.com> In-Reply-To: <1423052894-13125-1-git-send-email-armbru@redhat.com> References: <1423052894-13125-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 5/7] usb: Change usb_create_simple() to abort on failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com, afaerber@suse.de Instead of returning null pointer. Matches pci_create_simple(), isa_create_simple(), sysbus_create_simple(). It's unused since the previous commit, but I'll put it to use again shortly. Signed-off-by: Markus Armbruster --- hw/usb/bus.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index 5abfac0..d83a938 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -339,14 +339,7 @@ static USBDevice *usb_try_create_simple(USBBus *bus, const char *name, USBDevice *usb_create_simple(USBBus *bus, const char *name) { - Error *err = NULL; - USBDevice *dev = usb_try_create_simple(bus, name, &err); - - if (!dev) { - error_report("%s", error_get_pretty(err)); - error_free(err); - } - return dev; + return usb_try_create_simple(bus, name, &error_abort); } static void usb_fill_port(USBPort *port, void *opaque, int index, -- 1.9.3