qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: afaerber@suse.de
Subject: [Qemu-devel] [PATCH 0/8] Cleanups around unchecked qdev_init()
Date: Wed,  4 Feb 2015 18:33:00 +0100	[thread overview]
Message-ID: <1423071188-1085-1-git-send-email-armbru@redhat.com> (raw)

Board setup should normally use qdev_init_nofail(), not qdev_init(),
because inability to create an onboard device is normally fatal.
Board setup should certainly not ignore qdev_init() failure.  Even
when we know that realization can't actually fail now,
qdev_init_nofail() is clearer and more robust.  Correct a few obvious
instances.

Markus Armbruster (8):
  qdev: Improve qdev_init_nofail()'s error reporting
  ide/isa: Replace unchecked qdev_init() by qdev_init_nofail()
  leon3: Replace unchecked qdev_init() by qdev_init_nofail()
  etsec: Replace qdev_init() by qdev_init_nofail()
  serial: Factor out common serial_hds_isa_init()
  serial: serial_hds_isa_init() shouldn't fail
  parallel: Factor out common parallel_hds_isa_init()
  parallel: parallel_hds_isa_init() shouldn't fail

 hw/alpha/dp264.c         |  6 +-----
 hw/char/parallel.c       | 25 +++++++++++++++++++++++++
 hw/char/serial-isa.c     | 23 +++++++++++++++--------
 hw/core/qdev.c           | 11 ++++++++---
 hw/i386/pc.c             | 13 ++-----------
 hw/ide/isa.c             |  4 +---
 hw/mips/mips_fulong2e.c  | 12 ++----------
 hw/mips/mips_malta.c     |  7 +++----
 hw/mips/mips_r4k.c       |  6 +-----
 hw/net/fsl_etsec/etsec.c |  5 +----
 hw/sparc64/sun4u.c       | 12 ++----------
 include/hw/char/serial.h |  2 +-
 include/hw/i386/pc.h     | 17 +----------------
 include/hw/sparc/grlib.h | 12 +++---------
 14 files changed, 66 insertions(+), 89 deletions(-)

-- 
1.9.3

             reply	other threads:[~2015-02-04 17:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 17:33 Markus Armbruster [this message]
2015-02-04 17:33 ` [Qemu-devel] [PATCH 1/8] qdev: Improve qdev_init_nofail()'s error reporting Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 2/8] ide/isa: Replace unchecked qdev_init() by qdev_init_nofail() Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 3/8] leon3: " Markus Armbruster
2015-02-12  9:30   ` Fabien Chouteau
2015-02-04 17:33 ` [Qemu-devel] [PATCH 4/8] etsec: Replace " Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 5/8] serial: Factor out common serial_hds_isa_init() Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 6/8] serial: serial_hds_isa_init() shouldn't fail Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 7/8] parallel: Factor out common parallel_hds_isa_init() Markus Armbruster
2015-02-04 17:33 ` [Qemu-devel] [PATCH 8/8] parallel: parallel_hds_isa_init() shouldn't fail Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423071188-1085-1-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=afaerber@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).