From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ3pH-0005c6-3Y for qemu-devel@nongnu.org; Wed, 04 Feb 2015 12:33:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ3p9-0004EV-Fl for qemu-devel@nongnu.org; Wed, 04 Feb 2015 12:33:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ3p9-0004E7-8O for qemu-devel@nongnu.org; Wed, 04 Feb 2015 12:33:11 -0500 From: Markus Armbruster Date: Wed, 4 Feb 2015 18:33:04 +0100 Message-Id: <1423071188-1085-5-git-send-email-armbru@redhat.com> In-Reply-To: <1423071188-1085-1-git-send-email-armbru@redhat.com> References: <1423071188-1085-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 4/8] etsec: Replace qdev_init() by qdev_init_nofail() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: afaerber@suse.de etsec_create() is a helper to create and realize the eTSEC. It's currently unused. Similar helpers for other NICs use qdev_init_nofail(). Match that. Signed-off-by: Markus Armbruster --- hw/net/fsl_etsec/etsec.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c index 2fbbc6c..c57365f 100644 --- a/hw/net/fsl_etsec/etsec.c +++ b/hw/net/fsl_etsec/etsec.c @@ -443,10 +443,7 @@ DeviceState *etsec_create(hwaddr base, dev = qdev_create(NULL, "eTSEC"); qdev_set_nic_properties(dev, nd); - - if (qdev_init(dev)) { - return NULL; - } + qdev_init_nofail(dev); sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, tx_irq); sysbus_connect_irq(SYS_BUS_DEVICE(dev), 1, rx_irq); -- 1.9.3