From: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, mimu@linux.vnet.ibm.com,
mreitz@redhat.com
Subject: [Qemu-devel] [PATCH RFC v4 1/6] qemu-iotests: run qemu with -nodefaults
Date: Thu, 5 Feb 2015 11:44:27 +0800 [thread overview]
Message-ID: <1423107872-3268-2-git-send-email-chenxg@linux.vnet.ibm.com> (raw)
In-Reply-To: <1423107872-3268-1-git-send-email-chenxg@linux.vnet.ibm.com>
This patch fixes an io test suite issue that was introduced with the
commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only
a single "stdio" character device'. The option supresses the creation of
default devices.
Reviewed-by: Michael Mueller <mimu@linux.vnet.ibm.com>
Signed-off-by: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
---
tests/qemu-iotests/common | 1 +
tests/qemu-iotests/common.config | 2 +-
tests/qemu-iotests/common.qemu | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
index 1e556bb..ed26d79 100644
--- a/tests/qemu-iotests/common
+++ b/tests/qemu-iotests/common
@@ -51,6 +51,7 @@ export IMGOPTS=""
export CACHEMODE="writeback"
export QEMU_IO_OPTIONS=""
export CACHEMODE_IS_DEFAULT=true
+export QEMU_OPTIONS="-nodefaults"
for r
do
diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config
index a1973ad..cff91e1 100644
--- a/tests/qemu-iotests/common.config
+++ b/tests/qemu-iotests/common.config
@@ -103,7 +103,7 @@ if [ -z "$QEMU_NBD_PROG" ]; then
export QEMU_NBD_PROG="`set_prog_path qemu-nbd`"
fi
-export QEMU=$QEMU_PROG
+export QEMU="$QEMU_PROG $QEMU_OPTIONS"
export QEMU_IMG=$QEMU_IMG_PROG
export QEMU_IO="$QEMU_IO_PROG $QEMU_IO_OPTIONS"
export QEMU_NBD=$QEMU_NBD_PROG
diff --git a/tests/qemu-iotests/common.qemu b/tests/qemu-iotests/common.qemu
index 8e618b5..e35a797 100644
--- a/tests/qemu-iotests/common.qemu
+++ b/tests/qemu-iotests/common.qemu
@@ -153,7 +153,7 @@ function _launch_qemu()
mkfifo "${fifo_out}"
mkfifo "${fifo_in}"
- "${QEMU}" -nographic -serial none ${comm} -machine accel=qtest "${@}" \
+ ${QEMU} -nographic -serial none ${comm} -machine accel=qtest "${@}" \
>"${fifo_out}" \
2>&1 \
<"${fifo_in}" &
--
1.9.1
next prev parent reply other threads:[~2015-02-05 3:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 3:44 [Qemu-devel] [PATCH RFC v4 0/6] Update tests/qemu-iotests failing cases for the s390 platform Xiao Guang Chen
2015-02-05 3:44 ` Xiao Guang Chen [this message]
2015-02-05 3:52 ` [Qemu-devel] [PATCH RFC v4 1/6] qemu-iotests: run qemu with -nodefaults Fam Zheng
2015-02-05 5:52 ` chen xiao guang
2015-02-05 14:22 ` Max Reitz
2015-02-05 3:44 ` [Qemu-devel] [PATCH RFC v4 2/6] qemu-iotests: qemu machine type support Xiao Guang Chen
2015-02-05 14:18 ` Max Reitz
2015-02-05 17:57 ` Eric Blake
2015-02-05 3:44 ` [Qemu-devel] [PATCH RFC v4 3/6] qemu-iotests: fix tests 067, 071 and 087 Xiao Guang Chen
2015-02-05 3:44 ` [Qemu-devel] [PATCH RFC v4 4/6] qemu-iotests: s390x: fix test 041 Xiao Guang Chen
2015-02-05 14:26 ` Max Reitz
2015-02-05 3:44 ` [Qemu-devel] [PATCH RFC v4 5/6] qemu-iotests: s390x: fix test 051 Xiao Guang Chen
2015-02-05 15:11 ` Max Reitz
2015-02-09 8:06 ` chen xiao guang
2015-02-09 14:35 ` Max Reitz
2015-02-05 3:44 ` [Qemu-devel] [PATCH RFC v4 6/6] qemu-iotests: s390x: fix test 055 Xiao Guang Chen
2015-02-05 15:16 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423107872-3268-2-git-send-email-chenxg@linux.vnet.ibm.com \
--to=chenxg@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).