From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PULL 04/10] Print errors in some of the early migration failure cases.
Date: Thu, 5 Feb 2015 17:24:21 +0100 [thread overview]
Message-ID: <1423153467-13804-5-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1423153467-13804-1-git-send-email-quintela@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
savevm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/savevm.c b/savevm.c
index 1cc0f02..98895fe 100644
--- a/savevm.c
+++ b/savevm.c
@@ -883,16 +883,20 @@ int qemu_loadvm_state(QEMUFile *f)
QLIST_HEAD(, LoadStateEntry) loadvm_handlers =
QLIST_HEAD_INITIALIZER(loadvm_handlers);
LoadStateEntry *le, *new_le;
+ Error *local_err = NULL;
uint8_t section_type;
unsigned int v;
int ret;
- if (qemu_savevm_state_blocked(NULL)) {
+ if (qemu_savevm_state_blocked(&local_err)) {
+ error_report("%s", error_get_pretty(local_err));
+ error_free(local_err);
return -EINVAL;
}
v = qemu_get_be32(f);
if (v != QEMU_VM_FILE_MAGIC) {
+ error_report("Not a migration stream");
return -EINVAL;
}
@@ -902,6 +906,7 @@ int qemu_loadvm_state(QEMUFile *f)
return -ENOTSUP;
}
if (v != QEMU_VM_FILE_VERSION) {
+ error_report("Unsupported migration stream version");
return -ENOTSUP;
}
--
2.1.0
next prev parent reply other threads:[~2015-02-05 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 16:24 [Qemu-devel] [PULL 00/10] Migration queue Juan Quintela
2015-02-05 16:24 ` [Qemu-devel] [PULL 01/10] vmstate-static-checker: update whitelist Juan Quintela
2015-02-05 16:24 ` [Qemu-devel] [PULL 02/10] savevm: Convert fprintf to error_report Juan Quintela
2015-02-05 16:24 ` [Qemu-devel] [PULL 03/10] Migration: Add lots of trace events Juan Quintela
2015-02-05 16:24 ` Juan Quintela [this message]
2015-02-05 16:24 ` [Qemu-devel] [PULL 05/10] QJSON: Add JSON writer Juan Quintela
2015-02-05 16:24 ` [Qemu-devel] [PULL 06/10] qemu-file: Add fast ftell code path Juan Quintela
2015-02-05 16:24 ` [Qemu-devel] [PULL 07/10] migration: Append JSON description of migration stream Juan Quintela
2015-02-05 16:24 ` [Qemu-devel] [PULL 08/10] Add migration stream analyzation script Juan Quintela
2015-02-05 16:24 ` [Qemu-devel] [PULL 09/10] Tracify migration/rdma.c Juan Quintela
2015-02-05 16:24 ` [Qemu-devel] [PULL 10/10] fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail Juan Quintela
2015-02-06 10:38 ` [Qemu-devel] [PULL 00/10] Migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423153467-13804-5-git-send-email-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).