From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJRdN-0006kp-U1 for qemu-devel@nongnu.org; Thu, 05 Feb 2015 13:58:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJRdN-0002Dk-1j for qemu-devel@nongnu.org; Thu, 05 Feb 2015 13:58:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJRdM-0002DO-RL for qemu-devel@nongnu.org; Thu, 05 Feb 2015 13:58:36 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t15IwZRA026405 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 5 Feb 2015 13:58:36 -0500 From: Max Reitz Date: Thu, 5 Feb 2015 13:58:16 -0500 Message-Id: <1423162705-32065-8-git-send-email-mreitz@redhat.com> In-Reply-To: <1423162705-32065-1-git-send-email-mreitz@redhat.com> References: <1423162705-32065-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Max Reitz Signed-off-by: Max Reitz --- qemu-img.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 7154055..a67688d 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -293,32 +293,24 @@ static BlockBackend *img_open(const char *id, const char *filename, { BlockBackend *blk; BlockDriverState *bs; - BlockDriver *drv; char password[256]; Error *local_err = NULL; - int ret; - - blk = blk_new_with_bs(id, &error_abort); - bs = blk_bs(blk); + QDict *options = NULL; if (fmt) { - drv = bdrv_find_format(fmt); - if (!drv) { - error_report("Unknown file format '%s'", fmt); - goto fail; - } - } else { - drv = NULL; + options = qdict_new(); + qdict_put(options, "driver", qstring_from_str(fmt)); } - ret = bdrv_open(&bs, filename, NULL, NULL, flags, drv, &local_err); - if (ret < 0) { + blk = blk_new_open(id, filename, NULL, options, flags, &local_err); + if (!blk) { error_report("Could not open '%s': %s", filename, error_get_pretty(local_err)); error_free(local_err); goto fail; } + bs = blk_bs(blk); if (bdrv_is_encrypted(bs) && require_io) { qprintf(quiet, "Disk image '%s' is encrypted.\n", filename); if (read_password(password, sizeof(password)) < 0) { -- 2.1.0