From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJjzA-0003Si-MN for qemu-devel@nongnu.org; Fri, 06 Feb 2015 09:34:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJjz9-00044Q-EL for qemu-devel@nongnu.org; Fri, 06 Feb 2015 09:34:20 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:54960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJjz9-00043L-84 for qemu-devel@nongnu.org; Fri, 06 Feb 2015 09:34:19 -0500 From: Peter Maydell Date: Fri, 6 Feb 2015 14:34:10 +0000 Message-Id: <1423233250-15853-5-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1423233250-15853-1-git-send-email-peter.maydell@linaro.org> References: <1423233250-15853-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 4/4] target-arm: A64: Avoid signed shifts in disas_ldst_pair() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Richard Henderson , patches@linaro.org Avoid shifting potentially negative signed offset values in disas_ldst_pair() by keeping the offset in a uint64_t rather than an int64_t. Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 68c5b23..9f54501 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -1917,7 +1917,7 @@ static void disas_ldst_pair(DisasContext *s, uint32_t insn) int rt = extract32(insn, 0, 5); int rn = extract32(insn, 5, 5); int rt2 = extract32(insn, 10, 5); - int64_t offset = sextract32(insn, 15, 7); + uint64_t offset = sextract64(insn, 15, 7); int index = extract32(insn, 23, 2); bool is_vector = extract32(insn, 26, 1); bool is_load = extract32(insn, 22, 1); -- 1.9.1