From: Stefan Weil <sw@weilnetz.de>
To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>
Subject: [Qemu-devel] [PATCH 09/10] vga: Fix warning caused by missing 'static' attribute
Date: Fri, 6 Feb 2015 22:43:16 +0100 [thread overview]
Message-ID: <1423258997-30957-10-git-send-email-sw@weilnetz.de> (raw)
In-Reply-To: <1423258997-30957-1-git-send-email-sw@weilnetz.de>
Warning from the Sparse static analysis tool:
hw/display/vga.c:2012:26: warning:
symbol 'vmstate_vga_endian' was not declared. Should it be static?
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/display/vga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/vga.c b/hw/display/vga.c
index ffcfce3..9c62fbf 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -2032,7 +2032,7 @@ static bool vga_endian_state_needed(void *opaque)
return s->default_endian_fb != s->big_endian_fb;
}
-const VMStateDescription vmstate_vga_endian = {
+static const VMStateDescription vmstate_vga_endian = {
.name = "vga.endian",
.version_id = 1,
.minimum_version_id = 1,
--
2.1.4
next prev parent reply other threads:[~2015-02-07 10:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 21:43 [Qemu-devel] [PATCH 00/10] Fix warnings (undeclared global symbols) Stefan Weil
2015-02-06 21:43 ` [Qemu-devel] [PATCH 01/10] disas/cris: Fix warning caused by missing 'static' attribute Stefan Weil
2015-02-06 21:43 ` [Qemu-devel] [PATCH 02/10] disas/sh4: " Stefan Weil
2015-02-06 21:43 ` [Qemu-devel] [PATCH 03/10] migration: Fix warning caused by missing declaration of vmstate_dummy Stefan Weil
2015-02-06 21:43 ` [Qemu-devel] [PATCH 04/10] migration: Fix warnings caused by missing 'static' attribute Stefan Weil
2015-02-06 21:43 ` [Qemu-devel] [PATCH 05/10] moxie: Fix warning caused by missing include statement Stefan Weil
2015-02-06 21:43 ` [Qemu-devel] [PATCH 06/10] serial: Fix warnings caused by missing 'static' attribute Stefan Weil
2015-02-06 21:43 ` [Qemu-devel] [PATCH 07/10] spice: Add " Stefan Weil
2015-02-06 21:43 ` [Qemu-devel] [PATCH 08/10] stubs: Fix warning caused by missing include statement Stefan Weil
2015-02-06 21:43 ` Stefan Weil [this message]
2015-02-06 21:43 ` [Qemu-devel] [PATCH 10/10] virtio: Fix warning caused by missing 'static' attribute Stefan Weil
2015-02-08 10:49 ` [Qemu-devel] [Qemu-trivial] [PATCH 00/10] Fix warnings (undeclared global symbols) Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423258997-30957-10-git-send-email-sw@weilnetz.de \
--to=sw@weilnetz.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).