* [Qemu-devel] [PATCH] hmp: Fix warning from smatch (wrong argument in function call)
@ 2015-02-08 14:40 Stefan Weil
2015-02-09 9:40 ` Markus Armbruster
2015-02-10 19:08 ` Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2015-02-08 14:40 UTC (permalink / raw)
To: QEMU Trivial; +Cc: Stefan Weil, QEMU Developer, Luiz Capitulino
Fix this warning:
hmp.c:414:38: warning: Using plain integer as NULL pointer
qmp_query_block expects a pointer argument, so passing false is wrong.
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index a42c5c0..6926960 100644
--- a/hmp.c
+++ b/hmp.c
@@ -411,7 +411,7 @@ void hmp_info_block(Monitor *mon, const QDict *qdict)
/* Print BlockBackend information */
if (!nodes) {
- block_list = qmp_query_block(false);
+ block_list = qmp_query_block(NULL);
} else {
block_list = NULL;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hmp: Fix warning from smatch (wrong argument in function call)
2015-02-08 14:40 [Qemu-devel] [PATCH] hmp: Fix warning from smatch (wrong argument in function call) Stefan Weil
@ 2015-02-09 9:40 ` Markus Armbruster
2015-02-10 19:08 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2015-02-09 9:40 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Trivial, QEMU Developer, Luiz Capitulino
Stefan Weil <sw@weilnetz.de> writes:
> Fix this warning:
> hmp.c:414:38: warning: Using plain integer as NULL pointer
>
> qmp_query_block expects a pointer argument, so passing false is wrong.
>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hmp: Fix warning from smatch (wrong argument in function call)
2015-02-08 14:40 [Qemu-devel] [PATCH] hmp: Fix warning from smatch (wrong argument in function call) Stefan Weil
2015-02-09 9:40 ` Markus Armbruster
@ 2015-02-10 19:08 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2015-02-10 19:08 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial; +Cc: QEMU Developer, Luiz Capitulino
08.02.2015 17:40, Stefan Weil wrote:
> Fix this warning:
> hmp.c:414:38: warning: Using plain integer as NULL pointer
>
> qmp_query_block expects a pointer argument, so passing false is wrong.
Applied to -trivial. It turns out zero and zero are different! :)
Thanks,
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-10 19:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 14:40 [Qemu-devel] [PATCH] hmp: Fix warning from smatch (wrong argument in function call) Stefan Weil
2015-02-09 9:40 ` Markus Armbruster
2015-02-10 19:08 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).