From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKVYj-0007bP-Sl for qemu-devel@nongnu.org; Sun, 08 Feb 2015 12:22:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKVYe-0004Mn-GF for qemu-devel@nongnu.org; Sun, 08 Feb 2015 12:22:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKVYe-0004Ll-9v for qemu-devel@nongnu.org; Sun, 08 Feb 2015 12:22:08 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t18HM6NU006481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 8 Feb 2015 12:22:06 -0500 Message-ID: <1423416126.22865.668.camel@redhat.com> From: Alex Williamson Date: Sun, 08 Feb 2015 10:22:06 -0700 In-Reply-To: <54D66EE5.50207@redhat.com> References: <1423257311-1345-1-git-send-email-pbonzini@redhat.com> <1423273144.22865.654.camel@redhat.com> <54D66EE5.50207@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/3] vfio: free data and unmap BARs in instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Sat, 2015-02-07 at 21:00 +0100, Paolo Bonzini wrote: > > On 07/02/2015 02:39, Alex Williamson wrote: > > I'm not sure where it's coming from yet, but I did extensive testing for > > my last pull request based on ec6f25e because if I updated to d5fbb4c > > vfio hotplug broke immediately. I'll keep looking, but I thought I'd > > share in case you have some ideas. Thanks, > > I'm not sure I understand: d5fbb4c9ed52d97aebe5994d8a857c74c0d95a92 (RCU > merge) is an ancestor of ec6f25e788ef57ce1e9f734984ef8885172fd9e2 (s390 > merge) and the only patches in the middle are for s390. Ok, I went back to 83761b9244ad, applied 3a4dbe6aa934 to get the object_unparent() fix, then applied this series. Everything seems to work ok. Then I manually applied and bisected the commits that came in via d5fbb4c9ed52. I land on 374f2981d1f1 as introducing the segfault in memory_listener_register(). I guess I was mis-remembering where I did my testing for the last vfio pull request. My tag was based on ec6f25e, but I remember that I had to test based on a commit before the RCU merge. My test is to simply do virsh detach-device, attach-device in a loop for a vfio assigned VF NIC, 1s delay between ops. It typically fails within 100 to 150 iterations, I call 500 a pass. Thanks, Alex