From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hu Tao <hutao@cn.fujitsu.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PATCH 6/7] numa: Rename option parsing functions
Date: Sun, 8 Feb 2015 16:51:21 -0200 [thread overview]
Message-ID: <1423421482-11619-7-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1423421482-11619-1-git-send-email-ehabkost@redhat.com>
Renaming set_numa_nodes() and numa_init_func() to parse_numa_opts() and
parse_numa() makes the purpose of those functions clearer.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
include/sysemu/numa.h | 2 +-
numa.c | 6 +++---
vl.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h
index d25ada9..453b49a 100644
--- a/include/sysemu/numa.h
+++ b/include/sysemu/numa.h
@@ -16,7 +16,7 @@ typedef struct node_info {
bool present;
} NodeInfo;
extern NodeInfo numa_info[MAX_NODES];
-void set_numa_nodes(void);
+void parse_numa_opts(void);
void set_numa_modes(void);
void query_numa_node_mem(uint64_t node_mem[]);
extern QemuOptsList qemu_numa_opts;
diff --git a/numa.c b/numa.c
index eb9259b..d5b95e1 100644
--- a/numa.c
+++ b/numa.c
@@ -123,7 +123,7 @@ static void numa_node_parse(NumaNodeOptions *node, QemuOpts *opts, Error **errp)
max_numa_nodeid = MAX(max_numa_nodeid, nodenr + 1);
}
-static int numa_init_func(QemuOpts *opts, void *opaque)
+static int parse_numa(QemuOpts *opts, void *opaque)
{
NumaOptions *object = NULL;
Error *err = NULL;
@@ -166,11 +166,11 @@ error:
return -1;
}
-void set_numa_nodes(void)
+void parse_numa_opts(void)
{
int i;
- if (qemu_opts_foreach(qemu_find_opts("numa"), numa_init_func,
+ if (qemu_opts_foreach(qemu_find_opts("numa"), parse_numa,
NULL, 1) != 0) {
exit(1);
}
diff --git a/vl.c b/vl.c
index cfce820..7243216 100644
--- a/vl.c
+++ b/vl.c
@@ -4154,7 +4154,7 @@ int main(int argc, char **argv, char **envp)
default_drive(default_floppy, snapshot, IF_FLOPPY, 0, FD_OPTS);
default_drive(default_sdcard, snapshot, IF_SD, 0, SD_OPTS);
- set_numa_nodes();
+ parse_numa_opts();
if (qemu_opts_foreach(qemu_find_opts("mon"), mon_init_func, NULL, 1) != 0) {
exit(1);
--
2.1.0
next prev parent reply other threads:[~2015-02-08 18:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 18:51 [Qemu-devel] [PATCH 0/7] NUMA code cleanup Eduardo Habkost
2015-02-08 18:51 ` [Qemu-devel] [PATCH 1/7] numa: Move NUMA declarations from sysemu.h to numa.h Eduardo Habkost
2015-02-09 16:17 ` Michael S. Tsirkin
2015-02-08 18:51 ` [Qemu-devel] [PATCH 2/7] vl.c: Remove unnecessary zero-initialization of NUMA globals Eduardo Habkost
2015-02-08 18:51 ` [Qemu-devel] [PATCH 3/7] numa: Move NUMA globals to numa.c Eduardo Habkost
2015-02-08 18:51 ` [Qemu-devel] [PATCH 4/7] numa: Make max_numa_nodeid static Eduardo Habkost
2015-02-08 18:51 ` [Qemu-devel] [PATCH 5/7] numa: Move QemuOpts parsing to set_numa_nodes() Eduardo Habkost
2015-02-08 18:51 ` Eduardo Habkost [this message]
2015-02-08 18:51 ` [Qemu-devel] [PATCH 7/7] numa: Rename set_numa_modes() to numa_post_machine_init() Eduardo Habkost
2015-02-09 9:16 ` [Qemu-devel] [PATCH 0/7] NUMA code cleanup Paolo Bonzini
2015-02-09 14:53 ` Eduardo Habkost
2015-02-09 16:02 ` Paolo Bonzini
2015-02-09 16:20 ` Michael S. Tsirkin
2015-02-12 16:49 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423421482-11619-7-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).