From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKhYy-0008Oc-3Q for qemu-devel@nongnu.org; Mon, 09 Feb 2015 01:11:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKhYu-0006Po-UJ for qemu-devel@nongnu.org; Mon, 09 Feb 2015 01:11:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKhYu-0006Pj-Np for qemu-devel@nongnu.org; Mon, 09 Feb 2015 01:11:12 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t196BCNu031407 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 9 Feb 2015 01:11:12 -0500 Date: Mon, 09 Feb 2015 06:19:05 +0008 From: Jason Wang Message-Id: <1423462265.4366.2@smtp.corp.redhat.com> In-Reply-To: <20150208105101.GG3185@redhat.com> References: <1423209253-22222-1-git-send-email-jasowang@redhat.com> <1423209253-22222-3-git-send-email-jasowang@redhat.com> <20150208105101.GG3185@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Subject: Re: [Qemu-devel] [PATCH 2/5] virtio: increase VIRITO_QUEUE_MAX to 513 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Sun, Feb 8, 2015 at 6:51 PM, Michael S. Tsirkin wrote: > On Fri, Feb 06, 2015 at 03:54:10PM +0800, Jason Wang wrote: >> Recent linux kernel supports up to 256 tap queues. Increase the >> limit >> to 513 (256 * 2 + 1(ctrl vq)). >> >> Signed-off-by: Jason Wang > > We have a bunch of loops over all possible VQ numbers in virtio pci. > Doing this for 1000 VQs when most of them are inactive seems extreme > - I > suspect we need a list of active VQs now. We can do it on top of this series. But not sure it was really needed since none of those loops happen on data path. So we were probably ok. > > >> --- >> include/hw/virtio/virtio.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h >> index 220c09d..21bb30f 100644 >> --- a/include/hw/virtio/virtio.h >> +++ b/include/hw/virtio/virtio.h >> @@ -92,7 +92,7 @@ typedef struct VirtQueueElement >> struct iovec out_sg[VIRTQUEUE_MAX_SIZE]; >> } VirtQueueElement; >> >> -#define VIRTIO_QUEUE_MAX 64 >> +#define VIRTIO_QUEUE_MAX 513 >> >> #define VIRTIO_NO_VECTOR 0xffff >> >> -- >> 1.9.1 >