From: Ian Campbell <ian.campbell@citrix.com>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
qemu-devel@nongnu.org, xen-devel@lists.xen.org,
stefano.stabellini@citrix.com, kraxel@redhat.com
Subject: Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough
Date: Mon, 9 Feb 2015 11:05:10 +0000 [thread overview]
Message-ID: <1423479910.23098.34.camel@citrix.com> (raw)
In-Reply-To: <54D8537C.2080805@intel.com>
On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote:
> What about this?
I've not read the code in detail,since I'm travelling but from a quick
glance it looks to be implementing the sort of thing I meant, thanks.
A couple of higher level comments:
I'd suggest to put the code for reading the vid/did into a helper
function so it can be reused.
You might like to optionally consider add a forcing option somehow so
that people with new devices not in the list can control things without
the need to recompile (e.g. gfx_passthru_kind_override?). Perhaps that
isn't needed for a first cut though and it would be a libxl API so
thought required.
I think it should probably log something at a lowish level when it has
autodetected IGD.
Ian.
next prev parent reply other threads:[~2015-02-09 11:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 1:17 [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough Tiejun Chen
2015-02-02 11:08 ` Ian Campbell
2015-02-03 1:00 ` Chen, Tiejun
2015-02-02 12:19 ` Wei Liu
2015-02-02 12:54 ` Ian Jackson
2015-02-03 1:04 ` Chen, Tiejun
2015-02-03 11:07 ` Ian Campbell
2015-02-04 1:34 ` Chen, Tiejun
2015-02-04 10:41 ` Ian Campbell
2015-02-05 1:22 ` Chen, Tiejun
2015-02-05 9:52 ` [Qemu-devel] [Xen-devel] " Ian Campbell
2015-02-06 1:01 ` Chen, Tiejun
2015-02-09 6:28 ` Chen, Tiejun
2015-02-09 11:05 ` Ian Campbell [this message]
2015-02-11 2:45 ` Chen, Tiejun
2015-02-13 1:14 ` Chen, Tiejun
2015-02-18 13:22 ` Ian Campbell
2015-02-26 6:35 ` Chen, Tiejun
2015-02-26 16:17 ` Ian Campbell
2015-02-27 6:28 ` Chen, Tiejun
2015-02-27 11:04 ` Ian Campbell
2015-03-02 1:20 ` Chen, Tiejun
2015-03-03 10:06 ` Chen, Tiejun
2015-03-05 17:24 ` Ian Campbell
2015-02-03 1:01 ` [Qemu-devel] " Chen, Tiejun
2015-02-03 10:19 ` Wei Liu
2015-02-04 0:41 ` Chen, Tiejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423479910.23098.34.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@citrix.com \
--cc=tiejun.chen@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).