From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YKm9b-00074d-82
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 06:05:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YKm9X-0004n0-Sg
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 06:05:23 -0500
Received: from smtp02.citrix.com ([66.165.176.63]:29262)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YKm9X-0004mU-Oe
	for qemu-devel@nongnu.org; Mon, 09 Feb 2015 06:05:19 -0500
Message-ID: <1423479910.23098.34.camel@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Mon, 9 Feb 2015 11:05:10 +0000
In-Reply-To: <54D8537C.2080805@intel.com>
References: <1422839843-25622-1-git-send-email-tiejun.chen@intel.com>
	<20150202121940.GA28773@zion.uk.xensource.com>
	<21711.29549.892862.333392@mariner.uk.xensource.com>
	<54D01EAB.1020005@intel.com>	<1422961628.9323.32.camel@citrix.com>
	<54D1770C.4020904@intel.com>	<1423046493.17711.28.camel@citrix.com>
	<54D2C5E5.40407@intel.com>	<1423129922.24924.46.camel@citrix.com>
	<54D41274.9090400@intel.com> <54D8537C.2080805@intel.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine
 property to support IGD GFX passthrough
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, qemu-devel@nongnu.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, kraxel@redhat.com

On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote:

> What about this?

I've not read the code in detail,since I'm travelling but from a quick
glance it looks to be implementing the sort of thing I meant, thanks.

A couple of higher level comments:

I'd suggest to put the code for reading the vid/did into a helper
function so it can be reused.

You might like to optionally consider add a forcing option somehow so
that people with new devices not in the list can control things without
the need to recompile (e.g. gfx_passthru_kind_override?). Perhaps that
isn't needed for a first cut though and it would be a libxl API so
thought required.

I think it should probably log something at a lowish level when it has
autodetected IGD.

Ian.