From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKtEW-000460-PA for qemu-devel@nongnu.org; Mon, 09 Feb 2015 13:38:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKtEQ-0005OS-DQ for qemu-devel@nongnu.org; Mon, 09 Feb 2015 13:38:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKtEQ-0005Nv-5I for qemu-devel@nongnu.org; Mon, 09 Feb 2015 13:38:50 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t19Icm8v022263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 9 Feb 2015 13:38:49 -0500 From: Max Reitz Date: Mon, 9 Feb 2015 13:38:24 -0500 Message-Id: <1423507124-29809-3-git-send-email-mreitz@redhat.com> In-Reply-To: <1423507124-29809-1-git-send-email-mreitz@redhat.com> References: <1423507124-29809-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v2 02/22] iotests: Do not redirect qemu's stderr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Stefan Hajnoczi , Max Reitz Redirecting qemu's stderr to stdout makes working with the stderr output difficult due to the other file descriptor magic performed in _launch_qemu ("ambiguous redirect"). There is no harm in leaving stderr on stderr, so do it. Signed-off-by: Max Reitz --- If someone has a better solution, especially regarding the redirection to a subshell here (test 091) and in the next patch, I'd be very grateful. All of my efforts to pipe the output of the _launch_qemu function resulted in said error ("ambiguous redirect"), so I had to keep it on stderr and I did not find another way to pipe stderr to another program. --- tests/qemu-iotests/091 | 3 ++- tests/qemu-iotests/common.qemu | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091 index 32bbd56..caea1ce 100755 --- a/tests/qemu-iotests/091 +++ b/tests/qemu-iotests/091 @@ -68,7 +68,8 @@ echo echo === Starting QEMU VM2 === echo _launch_qemu -drive file="${TEST_IMG}",cache=${CACHEMODE},id=disk \ - -incoming "exec: cat '${MIG_FIFO}'" + -incoming "exec: cat '${MIG_FIFO}'" \ + 2> >(grep -v 'cat: write error') h2=$QEMU_HANDLE echo diff --git a/tests/qemu-iotests/common.qemu b/tests/qemu-iotests/common.qemu index 4e1996c..5f10c1e 100644 --- a/tests/qemu-iotests/common.qemu +++ b/tests/qemu-iotests/common.qemu @@ -155,7 +155,6 @@ function _launch_qemu() "${QEMU}" -nographic -serial none ${comm} -machine accel=qtest "${@}" \ >"${fifo_out}" \ - 2>&1 \ <"${fifo_in}" & QEMU_PID[${_QEMU_HANDLE}]=$! -- 2.1.0