From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKty5-0005Xf-MT for qemu-devel@nongnu.org; Mon, 09 Feb 2015 14:26:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKty4-0003U8-J2 for qemu-devel@nongnu.org; Mon, 09 Feb 2015 14:26:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKty4-0003Tx-Ck for qemu-devel@nongnu.org; Mon, 09 Feb 2015 14:26:00 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t19JPxWh014751 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 9 Feb 2015 14:26:00 -0500 From: Max Reitz Date: Mon, 9 Feb 2015 14:25:45 -0500 Message-Id: <1423509950-7468-8-git-send-email-mreitz@redhat.com> In-Reply-To: <1423509950-7468-1-git-send-email-mreitz@redhat.com> References: <1423509950-7468-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v3 07/12] qcow2/overlaps: Protect active L1 table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Max Reitz Keep track of the active L1 table in the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-cluster.c | 11 +++++++++++ block/qcow2-snapshot.c | 10 ++++++++++ block/qcow2.c | 4 ++++ 3 files changed, 25 insertions(+) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 183177d..bc93c00 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -125,6 +125,17 @@ int qcow2_grow_l1_table(BlockDriverState *bs, uint64_t min_size, s->l1_table = new_l1_table; old_l1_size = s->l1_size; s->l1_size = new_l1_size; + + qcow2_metadata_list_remove(bs, old_l1_table_offset, + size_to_clusters(s, old_l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); + + qcow2_metadata_list_enter(bs, s->l1_table_offset, + size_to_clusters(s, s->l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); + qcow2_free_clusters(bs, old_l1_table_offset, old_l1_size * sizeof(uint64_t), QCOW2_DISCARD_OTHER); return 0; diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 5b3903c..41ea053 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -720,6 +720,11 @@ int qcow2_snapshot_load_tmp(BlockDriverState *bs, return ret; } + qcow2_metadata_list_remove(bs, s->l1_table_offset, + size_to_clusters(s, s->l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); + /* Switch the L1 table */ qemu_vfree(s->l1_table); @@ -731,5 +736,10 @@ int qcow2_snapshot_load_tmp(BlockDriverState *bs, be64_to_cpus(&s->l1_table[i]); } + qcow2_metadata_list_enter(bs, s->l1_table_offset, + size_to_clusters(s, s->l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); + return 0; } diff --git a/block/qcow2.c b/block/qcow2.c index e9f4824..f285555 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -832,6 +832,10 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags, } s->l1_table_offset = header.l1_table_offset; + qcow2_metadata_list_enter(bs, s->l1_table_offset, + size_to_clusters(s, s->l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); if (s->l1_size > 0) { s->l1_table = qemu_try_blockalign(bs->file, -- 2.1.0