From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKuOj-0004Cw-C8 for qemu-devel@nongnu.org; Mon, 09 Feb 2015 14:53:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKuOe-0006SN-9a for qemu-devel@nongnu.org; Mon, 09 Feb 2015 14:53:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKuOe-0006SG-3C for qemu-devel@nongnu.org; Mon, 09 Feb 2015 14:53:28 -0500 From: Eduardo Habkost Date: Mon, 9 Feb 2015 17:53:14 -0200 Message-Id: <1423511596-2584-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1423511596-2584-1-git-send-email-ehabkost@redhat.com> References: <1423511596-2584-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/3] numa: Reject CPU indexes > max_cpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Igor Mammedov , Hu Tao , "Michael S. Tsirkin" The CPU indexes for NUMA nodes make sense only up to max_cpus, and CPU indexes > max_cpus are ignored. Reject configuration which uses invalid CPU indexes. Signed-off-by: Eduardo Habkost --- numa.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/numa.c b/numa.c index 0d15375..f768434 100644 --- a/numa.c +++ b/numa.c @@ -76,9 +76,10 @@ static void numa_node_parse(NumaNodeOptions *node, QemuOpts *opts, Error **errp) } for (cpus = node->cpus; cpus; cpus = cpus->next) { - if (cpus->value > MAX_CPUMASK_BITS) { - error_setg(errp, "CPU number %" PRIu16 " is bigger than %d", - cpus->value, MAX_CPUMASK_BITS); + if (cpus->value > max_cpus) { + error_setg(errp, + "CPU number %" PRIu16 " is bigger than maxcpus (%d)", + cpus->value, max_cpus); return; } bitmap_set(numa_info[nodenr].node_cpu, cpus->value, 1); -- 2.1.0