From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL6zV-0006tQ-Nq for qemu-devel@nongnu.org; Tue, 10 Feb 2015 04:20:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YL6zU-0002u4-JY for qemu-devel@nongnu.org; Tue, 10 Feb 2015 04:20:21 -0500 Message-ID: <1423559998.488.9.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 10 Feb 2015 10:19:58 +0100 In-Reply-To: <1423542976-8825-2-git-send-email-david@gibson.dropbear.id.au> References: <1423542976-8825-1-git-send-email-david@gibson.dropbear.id.au> <1423542976-8825-2-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] vga: Expose framebuffer byteorder as a QOM property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, mdroth@us.ibm.com On Di, 2015-02-10 at 15:36 +1100, David Gibson wrote: > The VGA device model now supports having the framebuffer in either endian, > and can be switched between these by the guest via a register in the qext > region. > > However, in some cases (e.g. LE OS on the pseries machine) we have > existing guest that don't know about the endian switch register, but other > parts of the qemu code have better information to set a default endianness > than the VGA code does of itself. > > In order to allow them to set a correct default endianness in these cases, > without breaking abstraction walls, this patch exposes the VGA framebuffer > endianness via a writable QOM property. > > Signed-off-by: David Gibson > > prop fixup squash leftover? Otherwise: Reviewed-by: Gerd Hoffmann (assuming this little series gets in via ppc tree). cheers, Gerd