From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 9/9] qemu-char: Avoid qerror_report_err() outside QMP command handlers
Date: Tue, 10 Feb 2015 17:34:15 +0100 [thread overview]
Message-ID: <1423586055-4932-10-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1423586055-4932-1-git-send-email-armbru@redhat.com>
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere. Replace by error_report_err() in legacy chardev parser
qemu_chr_parse_compat(). Legacy chardev syntax is not to be used in
QMP.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qemu-char.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index f901ed1..8159462 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3306,8 +3306,7 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename)
opts = qemu_opts_create(qemu_find_opts("chardev"), label, 1, &local_err);
if (local_err) {
- qerror_report_err(local_err);
- error_free(local_err);
+ error_report_err(local_err);
return NULL;
}
--
1.9.3
next prev parent reply other threads:[~2015-02-10 16:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 16:34 [Qemu-devel] [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err() Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err() Markus Armbruster
2015-02-10 16:44 ` Paolo Bonzini
2015-02-10 22:04 ` Eduardo Habkost
2015-02-11 10:17 ` Paolo Bonzini
2015-02-11 13:13 ` [Qemu-devel] Coccinelle semantic patches (was Re: [PATCH 1/9] error: New convenience function error_report_err()) Eduardo Habkost
2015-02-11 12:47 ` [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err() Markus Armbruster
2015-02-10 17:20 ` Eric Blake
2015-02-11 10:04 ` Kevin Wolf
2015-02-11 12:24 ` Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param() Markus Armbruster
2015-02-10 21:09 ` Eric Blake
2015-02-10 16:34 ` [Qemu-devel] [PATCH 3/9] monitor: Avoid qerror_report_err() outside QMP command handlers Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 4/9] net: " Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 5/9] numa: " Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 6/9] tpm: " Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 7/9] vl: " Markus Armbruster
2015-02-10 16:34 ` [Qemu-devel] [PATCH 8/9] qemu-img: " Markus Armbruster
2015-02-10 16:34 ` Markus Armbruster [this message]
2015-02-11 15:28 ` [Qemu-devel] [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err() Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423586055-4932-10-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).