From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38682)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1YLDqQ-00013t-5p
	for qemu-devel@nongnu.org; Tue, 10 Feb 2015 11:39:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1YLDqP-0000HC-AW
	for qemu-devel@nongnu.org; Tue, 10 Feb 2015 11:39:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60101)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1YLDqP-0000H1-3f
	for qemu-devel@nongnu.org; Tue, 10 Feb 2015 11:39:25 -0500
Message-ID: <1423586359.22865.811.camel@redhat.com>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Tue, 10 Feb 2015 09:39:19 -0700
In-Reply-To: <f73ff075e2b33d8ecd0be330b11041c07e2d1b35.1423551266.git.chen.fan.fnst@cn.fujitsu.com>
References: <cover.1423551266.git.chen.fan.fnst@cn.fujitsu.com>
	<f73ff075e2b33d8ecd0be330b11041c07e2d1b35.1423551266.git.chen.fan.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v3 06/10] piix: disable all vfio device
	aercap property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Cc: izumi.taku@jp.fujitsu.com, qemu-devel@nongnu.org

On Tue, 2015-02-10 at 15:03 +0800, Chen Fan wrote:
> because at i440FX platform, all pcie device don't support aer capability,
> so for all vfio device, we don't need to expose the aer capability.
> 
> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> ---
>  hw/i386/pc_piix.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 38b42b0..8001313 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -71,6 +71,20 @@ static bool smbios_uuid_encoded = true;
>  static bool gigabyte_align = true;
>  static bool has_reserved_memory = true;
>  
> +static void pc_props_register_global(void) {
> +
> +    static GlobalProperty globalPropertys[] = {
> +       {
> +           .driver   = "vfio-pci",
> +           .property = "aercap",
> +           .value    = "off",
> +        },
> +        { /* end of list */ }
> +    };
> +
> +    qdev_prop_register_global_list(globalPropertys);
> +}
> +

Does this compile?  vfio-pci doesn't have that property until a later
patch.

>  /* PC hardware initialisation */
>  static void pc_init1(MachineState *machine,
>                       int pci_enabled,
> @@ -301,6 +315,8 @@ static void pc_init1(MachineState *machine,
>      if (pci_enabled) {
>          pc_pci_device_init(pci_bus);
>      }
> +
> +    pc_props_register_global();
>  }
>  
>  static void pc_init_pci(MachineState *machine)