From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v6 10/24] qcow2: Open images with refcount order != 4
Date: Tue, 10 Feb 2015 15:28:52 -0500 [thread overview]
Message-ID: <1423600146-7642-11-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1423600146-7642-1-git-send-email-mreitz@redhat.com>
No longer refuse to open images with a different refcount entry width
than 16 bits; only reject images with a refcount width larger than 64
bits (which is prohibited by the specification).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/qcow2.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 830c903..e563a30 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -677,10 +677,10 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags,
}
/* Check support for various header values */
- if (header.refcount_order != 4) {
- report_unsupported(bs, errp, "%d bit reference counts",
- 1 << header.refcount_order);
- ret = -ENOTSUP;
+ if (header.refcount_order > 6) {
+ error_setg(errp, "Reference count entry width too large; may not "
+ "exceed 64 bits");
+ ret = -EINVAL;
goto fail;
}
s->refcount_order = header.refcount_order;
--
2.1.0
next prev parent reply other threads:[~2015-02-10 20:29 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 20:28 [Qemu-devel] [PATCH v6 00/24] qcow2: Support refcount orders != 4 Max Reitz
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 01/24] qcow2: Add two new fields to BDRVQcowState Max Reitz
2015-02-11 13:51 ` Eric Blake
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 02/24] qcow2: Add refcount_bits to format-specific info Max Reitz
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 03/24] qcow2: Do not return new value after refcount update Max Reitz
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 04/24] qcow2: Only return status from qcow2_get_refcount Max Reitz
2015-02-11 15:47 ` Eric Blake
2015-02-17 10:19 ` Kevin Wolf
2015-02-17 16:56 ` Eric Blake
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 05/24] qcow2: Use unsigned addend for update_refcount() Max Reitz
2015-02-11 16:41 ` Eric Blake
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 06/24] qcow2: Use 64 bits for refcount values Max Reitz
2015-02-11 17:01 ` Eric Blake
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 07/24] qcow2: Helper for refcount array reallocation Max Reitz
2015-02-11 18:19 ` Eric Blake
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 08/24] qcow2: Helper function for refcount modification Max Reitz
2015-02-11 18:38 ` Eric Blake
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 09/24] qcow2: More helpers " Max Reitz
2015-02-17 13:38 ` Kevin Wolf
2015-02-17 13:54 ` Max Reitz
2015-02-10 20:28 ` Max Reitz [this message]
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 11/24] qcow2: refcount_order parameter for qcow2_create2 Max Reitz
2015-02-18 11:05 ` Kevin Wolf
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 12/24] qcow2: Use symbolic macros in qcow2_amend_options Max Reitz
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 13/24] iotests: Prepare for refcount_bits option Max Reitz
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 14/24] qcow2: Allow creation with refcount order != 4 Max Reitz
2015-02-18 11:01 ` Kevin Wolf
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 15/24] progress: Allow regressing progress Max Reitz
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 16/24] block: Add opaque value to the amend CB Max Reitz
2015-02-10 20:28 ` [Qemu-devel] [PATCH v6 17/24] qcow2: Use error_report() in qcow2_amend_options() Max Reitz
2015-02-10 20:29 ` [Qemu-devel] [PATCH v6 18/24] qcow2: Use abort() instead of assert(false) Max Reitz
2015-02-10 20:29 ` [Qemu-devel] [PATCH v6 19/24] qcow2: Split upgrade/downgrade paths for amend Max Reitz
2015-02-10 20:29 ` [Qemu-devel] [PATCH v6 20/24] qcow2: Use intermediate helper CB " Max Reitz
2015-02-10 20:29 ` [Qemu-devel] [PATCH v6 21/24] qcow2: Add function for refcount order amendment Max Reitz
2015-02-10 20:29 ` [Qemu-devel] [PATCH v6 22/24] qcow2: Invoke refcount order amendment function Max Reitz
2015-02-10 20:29 ` [Qemu-devel] [PATCH v6 23/24] qcow2: Point to amend function in check Max Reitz
2015-02-10 20:29 ` [Qemu-devel] [PATCH v6 24/24] iotests: Add test for different refcount widths Max Reitz
2015-02-18 11:04 ` Kevin Wolf
2015-02-17 11:00 ` [Qemu-devel] [PATCH v6 00/24] qcow2: Support refcount orders != 4 Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423600146-7642-11-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).