From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLVVN-0005VJ-BJ for qemu-devel@nongnu.org; Wed, 11 Feb 2015 06:30:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLVVK-0005Gx-5B for qemu-devel@nongnu.org; Wed, 11 Feb 2015 06:30:53 -0500 Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 11 Feb 2015 12:30:43 +0100 Message-Id: <1423654243-20992-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] cutils: refine strtol error handling in parse_debug_env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Avoid truncation of a 64-bit long to a 32-bit int, and check for errno (especially ERANGE). Signed-off-by: Paolo Bonzini --- v1->v2: clear errno before strtol --- util/cutils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/util/cutils.c b/util/cutils.c index dbe7412..9312e45 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -523,16 +523,17 @@ int parse_debug_env(const char *name, int max, int initial) { char *debug_env = getenv(name); char *inv = NULL; - int debug; + long debug; if (!debug_env) { return initial; } + errno = 0; debug = strtol(debug_env, &inv, 10); if (inv == debug_env) { return initial; } - if (debug < 0 || debug > max) { + if (debug < 0 || debug > max || errno != 0) { fprintf(stderr, "warning: %s not in [0, %d]", name, max); return initial; } -- 1.8.3.1