From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] vnc: fix coverity warning
Date: Wed, 11 Feb 2015 17:48:16 +0100 [thread overview]
Message-ID: <1423673296.15339.11.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <54DB8656.8050401@redhat.com>
> > + assert(vs);
> > return vnc_socket_local_addr("%s:%s", vs->lsock);
> > }
> >
> >
>
> If you want, I can just silence the warning in Coverity.
I think in the source code is better, human readers might wonder too.
And in case the calling code ever changes behavior the assert will trap
it (even though it is highly unlikely in this specific case).
cheers,
Gerd
next prev parent reply other threads:[~2015-02-11 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 16:37 [Qemu-devel] [PATCH] vnc: fix coverity warning Gerd Hoffmann
2015-02-11 16:41 ` Paolo Bonzini
2015-02-11 16:48 ` Gerd Hoffmann [this message]
2015-02-12 9:27 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423673296.15339.11.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).