From: Wen Congyang <wency@cn.fujitsu.com>
To: qemu devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Gonglei <arei.gonglei@huawei.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: [Qemu-devel] [RFC PATCH 02/14] quorom: add a new read pattern
Date: Thu, 12 Feb 2015 11:07:06 +0800 [thread overview]
Message-ID: <1423710438-14377-3-git-send-email-wency@cn.fujitsu.com> (raw)
In-Reply-To: <1423710438-14377-1-git-send-email-wency@cn.fujitsu.com>
To block replication, we only need to read from the first child.
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
---
block/quorum.c | 5 +++--
qapi/block-core.json | 4 +++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/block/quorum.c b/block/quorum.c
index 437b122..5ed1ff8 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -286,9 +286,10 @@ static void quorum_aio_cb(void *opaque, int ret)
BDRVQuorumState *s = acb->common.bs->opaque;
bool rewrite = false;
- if (acb->is_read && s->read_pattern == QUORUM_READ_PATTERN_FIFO) {
+ if (acb->is_read && s->read_pattern != QUORUM_READ_PATTERN_QUORUM) {
/* We try to read next child in FIFO order if we fail to read */
- if (ret < 0 && ++acb->child_iter < s->num_children) {
+ if (s->read_pattern == QUORUM_READ_PATTERN_FIFO &&
+ ret < 0 && ++acb->child_iter < s->num_children) {
read_fifo_child(acb);
return;
}
diff --git a/qapi/block-core.json b/qapi/block-core.json
index a3fdaf0..d6382e9 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1618,9 +1618,11 @@
#
# @fifo: read only from the first child that has not failed
#
+# @first: read only from the first child
+#
# Since: 2.2
##
-{ 'enum': 'QuorumReadPattern', 'data': [ 'quorum', 'fifo' ] }
+{ 'enum': 'QuorumReadPattern', 'data': [ 'quorum', 'fifo', 'first' ] }
##
# @BlockdevOptionsQuorum
--
2.1.0
next prev parent reply other threads:[~2015-02-12 3:05 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 3:07 [Qemu-devel] [RFC PATCH 00/14] Block replication for continuous checkpoints Wen Congyang
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description Wen Congyang
2015-02-12 7:21 ` Fam Zheng
2015-02-12 7:40 ` Wen Congyang
2015-02-12 8:44 ` Fam Zheng
2015-02-12 9:33 ` Wen Congyang
2015-02-12 9:44 ` Fam Zheng
2015-02-12 10:11 ` Wen Congyang
2015-02-12 10:26 ` famz
2015-02-13 5:09 ` Wen Congyang
2015-02-13 7:01 ` Fam Zheng
2015-02-13 20:29 ` John Snow
2015-03-03 7:53 ` Wen Congyang
2015-03-03 7:59 ` Fam Zheng
2015-03-03 12:12 ` Wen Congyang
2015-03-11 6:44 ` Wen Congyang
2015-03-11 6:49 ` Fam Zheng
2015-03-11 7:01 ` Wen Congyang
2015-03-11 7:04 ` Fam Zheng
2015-03-11 7:12 ` Wen Congyang
2015-03-13 9:01 ` Wen Congyang
2015-03-13 9:05 ` Fam Zheng
2015-03-16 6:19 ` Wen Congyang
2015-03-25 12:41 ` Paolo Bonzini
2015-02-12 9:36 ` Hongyang Yang
2015-02-12 9:46 ` Fam Zheng
2015-02-24 7:50 ` Wen Congyang
2015-02-25 2:46 ` Fam Zheng
2015-02-25 8:36 ` Wen Congyang
2015-02-25 8:58 ` Fam Zheng
2015-02-25 9:58 ` Wen Congyang
2015-02-26 6:38 ` Wen Congyang
2015-02-26 8:44 ` Fam Zheng
2015-02-26 9:07 ` Wen Congyang
2015-02-26 10:02 ` Fam Zheng
2015-02-27 2:27 ` Wen Congyang
2015-02-27 2:32 ` Fam Zheng
2015-02-25 8:11 ` Wen Congyang
2015-02-25 8:18 ` Fam Zheng
2015-02-25 9:10 ` Wen Congyang
2015-02-25 9:45 ` Fam Zheng
2015-03-04 16:35 ` Dr. David Alan Gilbert
2015-03-05 1:03 ` Wen Congyang
2015-03-05 19:04 ` Dr. David Alan Gilbert
2015-02-12 3:07 ` Wen Congyang [this message]
2015-02-12 6:42 ` [Qemu-devel] [RFC PATCH 02/14] quorom: add a new read pattern Gonglei
2015-02-23 20:36 ` Max Reitz
2015-02-23 21:56 ` Eric Blake
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 03/14] quorum: ignore 0-length child Wen Congyang
2015-02-23 20:43 ` Max Reitz
2015-02-24 2:33 ` Wen Congyang
2015-03-18 5:29 ` Wen Congyang
2015-03-18 12:57 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 04/14] Add new block driver interfaces to control disk replication Wen Congyang
2015-02-23 20:57 ` Max Reitz
2015-02-23 21:58 ` Eric Blake
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 05/14] quorom: implement block driver interfaces for block replication Wen Congyang
2015-02-23 21:22 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later Wen Congyang
2015-02-23 21:31 ` Max Reitz
2015-02-25 2:23 ` Wen Congyang
2015-02-25 14:22 ` Max Reitz
2015-02-26 14:07 ` Paolo Bonzini
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 07/14] NBD client: implement block driver interfaces for block replication Wen Congyang
2015-02-23 21:41 ` Max Reitz
2015-02-26 14:08 ` Paolo Bonzini
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 08/14] block: add a new API to create a hidden BlockBackend Wen Congyang
2015-02-23 21:48 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 09/14] block: give backing image its own BlockBackend Wen Congyang
2015-02-23 21:53 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 10/14] allow the backing image access the origin BlockDriverState Wen Congyang
2015-02-23 22:01 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 11/14] allow writing to the backing file Wen Congyang
2015-02-23 22:03 ` Max Reitz
2015-02-26 14:15 ` Paolo Bonzini
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 12/14] Add disk buffer for block replication Wen Congyang
2015-02-23 22:27 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 13/14] COW: move cow interfaces to a seperate file Wen Congyang
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 14/14] COLO: implement a new block driver Wen Congyang
2015-02-23 22:35 ` Max Reitz
2015-02-18 16:26 ` [Qemu-devel] [RFC PATCH 00/14] Block replication for continuous checkpoints Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423710438-14377-3-git-send-email-wency@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kwolf@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).