qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
	stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] virtio-scsi: Fix unsafe bdrv_set_aio_context calls
Date: Thu, 12 Feb 2015 13:20:59 +0800	[thread overview]
Message-ID: <1423718462-25566-1-git-send-email-famz@redhat.com> (raw)

It is not safe to call bdrv_set_aio_context outside BQL (see patch 1), so move
the call to main thread (patch 3). And as a bonus, the two loops in
virtio-scsi.c and virtio-scsi-dataplane.c for cmd queue handling are converged
(patch 2).


Fam Zheng (3):
  block: Forbid bdrv_set_aio_context outside BQL
  virtio-scsi: Deduplicate cmd queue handling code of dataplane
  virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

 hw/scsi/virtio-scsi-dataplane.c |  26 +++----
 hw/scsi/virtio-scsi.c           | 153 ++++++++++++++++++++++++++++++++++------
 include/block/block.h           |   3 +-
 include/hw/virtio/virtio-scsi.h |  11 ++-
 4 files changed, 156 insertions(+), 37 deletions(-)

-- 
1.9.3

             reply	other threads:[~2015-02-12  5:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12  5:20 Fam Zheng [this message]
2015-02-12  5:21 ` [Qemu-devel] [PATCH 1/3] block: Forbid bdrv_set_aio_context outside BQL Fam Zheng
2015-02-13 13:10   ` Paolo Bonzini
2015-03-10 13:34   ` Stefan Hajnoczi
2015-02-12  5:21 ` [Qemu-devel] [PATCH 2/3] virtio-scsi: Deduplicate cmd queue handling code of dataplane Fam Zheng
2015-02-12  5:21 ` [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context Fam Zheng
2015-02-12 14:29   ` Paolo Bonzini
2015-02-13  1:21     ` Fam Zheng
2015-02-13  9:38       ` Paolo Bonzini
2015-02-13 10:29         ` Fam Zheng
2015-02-13 10:38           ` Paolo Bonzini
2015-02-13 12:42             ` Fam Zheng
2015-02-13 13:12               ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423718462-25566-1-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).