qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jens Freimann <jfrei@linux.vnet.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: Jens Freimann <jfrei@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END
Date: Thu, 12 Feb 2015 14:08:53 +0100	[thread overview]
Message-ID: <1423746533-45739-3-git-send-email-jfrei@linux.vnet.ibm.com> (raw)
In-Reply-To: <1423746533-45739-1-git-send-email-jfrei@linux.vnet.ibm.com>

We have defines for VIRTIO_TRANSPORT_F_START/_END in two places.
In include/hw/virtio/virtio.h and in linux-headers/linux/virtio_config.h

Since we already get virtio_config.h via update-linux-headers.sh,
there's no need to have duplicate defines in QEMU headers files.

Let's remove this define from include/hw/virtio/virtio.h

Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
---
 include/hw/virtio/virtio.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index f24997d..f0350db 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -35,11 +35,6 @@
 /* We've given up on this device. */
 #define VIRTIO_CONFIG_S_FAILED          0x80
 
-/* Some virtio feature bits (currently bits 28 through 31) are reserved for the
- * transport being used (eg. virtio_ring), the rest are per-device feature bits. */
-#define VIRTIO_TRANSPORT_F_START        28
-#define VIRTIO_TRANSPORT_F_END          32
-
 /* We notify when the ring is completely used, even if the guest is suppressing
  * callbacks */
 #define VIRTIO_F_NOTIFY_ON_EMPTY        24
-- 
2.1.4

  parent reply	other threads:[~2015-02-12 13:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 13:08 [Qemu-devel] [PATCH/RFC 0/2] update-linux-headers.sh and virtio Jens Freimann
2015-02-12 13:08 ` [Qemu-devel] [PATCH 1/2] update-linux-headers.sh: also grap virtio_types.h Jens Freimann
2015-02-12 13:08 ` Jens Freimann [this message]
2015-02-12 14:41   ` [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END Peter Maydell
2015-02-12 14:53     ` Jens Freimann
2015-02-19 10:07       ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423746533-45739-3-git-send-email-jfrei@linux.vnet.ibm.com \
    --to=jfrei@linux.vnet.ibm.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).