From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLtuF-0002sE-Uh for qemu-devel@nongnu.org; Thu, 12 Feb 2015 08:34:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLtuA-0002UQ-AX for qemu-devel@nongnu.org; Thu, 12 Feb 2015 08:34:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLtuA-0002UB-3h for qemu-devel@nongnu.org; Thu, 12 Feb 2015 08:34:06 -0500 From: Markus Armbruster Date: Thu, 12 Feb 2015 14:33:50 +0100 Message-Id: <1423748040-3448-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Gerd Hoffmann , Stefan Hajnoczi , =?UTF-8?q?Andreas=20F=C3=A4rber?= Tree-wide cleanup, but the tree-wide changes are mechanical. If nobody objects, I'll route it through my own tree. Depends on my "[PATCH] vhost-scsi: Improve error reporting for invalid vhostfd". PATCH 01 introduces a helper function, PATCH 02 puts it to use. Responsible for the bulk of the diffstat. I could split off one or more of block, arm, x86+pci, scsi, usb, char, net for maintainers to pick up after the main patch got in. Cc'ing a few maintainers who might prefer that, to give them a chance to ask for it. PATCH 03 gets rid of an unnecessary use of qerror_report_err(). This is the patch that causes the dependency mentioned above. The remaining patches clean up inappropriate uses of qerror_report_err(). Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: Peter Maydell Cc: Michael S. Tsirkin Cc: Jason Wang Cc: Gerd Hoffmann Cc: Andreas F=C3=A4rber v2: * Split PATCH 01 into 01 and 02 [Eric, Kevin] * Rebased, PATCH 02 picked up another hunk * Remaining patches unchanged, R-by retained Markus Armbruster (10): error: New convenience function error_report_err() error: Use error_report_err() where appropriate monitor: Clean up around monitor_handle_fd_param() monitor: Avoid qerror_report_err() outside QMP command handlers net: Avoid qerror_report_err() outside QMP command handlers numa: Avoid qerror_report_err() outside QMP command handlers tpm: Avoid qerror_report_err() outside QMP command handlers vl: Avoid qerror_report_err() outside QMP command handlers qemu-img: Avoid qerror_report_err() outside QMP command handlers qemu-char: Avoid qerror_report_err() outside QMP command handlers arch_init.c | 3 +-- block/sheepdog.c | 39 +++++++++++++-------------------------- blockdev.c | 12 ++++-------- hw/arm/exynos4210.c | 4 ++-- hw/arm/highbank.c | 4 ++-- hw/arm/integratorcp.c | 4 ++-- hw/arm/realview.c | 6 +++--- hw/arm/versatilepb.c | 4 ++-- hw/arm/vexpress.c | 2 +- hw/arm/xilinx_zynq.c | 8 ++++---- hw/block/virtio-blk.c | 3 +-- hw/char/serial.c | 6 ++---- hw/i386/kvm/pci-assign.c | 14 +++++--------- hw/i386/pc.c | 5 ++--- hw/i386/smbios.c | 14 +++++++------- hw/ide/qdev.c | 3 +-- hw/pci/pci-hotplug-old.c | 3 +-- hw/pci/pci.c | 3 +-- hw/scsi/vhost-scsi.c | 2 +- hw/usb/dev-network.c | 3 +-- hw/usb/host-libusb.c | 3 +-- hw/usb/redirect.c | 3 +-- include/monitor/monitor.h | 3 +-- include/qapi/error.h | 5 +++++ monitor.c | 18 ++---------------- net/net.c | 9 +++------ net/socket.c | 4 +++- net/tap.c | 11 ++++++++--- numa.c | 8 +++----- qemu-char.c | 6 ++---- qemu-img.c | 9 +++------ qemu-io.c | 3 +-- qemu-nbd.c | 12 ++++-------- qom/cpu.c | 3 +-- target-i386/cpu.c | 3 +-- target-sparc/cpu.c | 3 +-- tpm.c | 6 ++---- util/error.c | 14 ++++++++++---- util/qemu-config.c | 9 +++------ vl.c | 21 ++++++++------------- 40 files changed, 119 insertions(+), 176 deletions(-) --=20 1.9.3