From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 04/10] monitor: Avoid qerror_report_err() outside QMP command handlers
Date: Thu, 12 Feb 2015 14:33:54 +0100 [thread overview]
Message-ID: <1423748040-3448-5-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1423748040-3448-1-git-send-email-armbru@redhat.com>
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere. Replace by error_report_err() in HMP command handler
hmp_trace_event().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
monitor.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index ac2a4ab..b109188 100644
--- a/monitor.c
+++ b/monitor.c
@@ -889,8 +889,7 @@ static void do_trace_event_set_state(Monitor *mon, const QDict *qdict)
qmp_trace_event_set_state(tp_name, new_state, true, true, &local_err);
if (local_err) {
- qerror_report_err(local_err);
- error_free(local_err);
+ error_report_err(local_err);
}
}
--
1.9.3
next prev parent reply other threads:[~2015-02-12 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 13:33 [Qemu-devel] [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err() Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 01/10] error: New convenience function error_report_err() Markus Armbruster
2015-02-12 15:26 ` Eric Blake
2015-02-13 8:08 ` Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 02/10] error: Use error_report_err() where appropriate Markus Armbruster
2015-02-12 15:29 ` Eric Blake
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 03/10] monitor: Clean up around monitor_handle_fd_param() Markus Armbruster
2015-02-12 13:33 ` Markus Armbruster [this message]
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 05/10] net: Avoid qerror_report_err() outside QMP command handlers Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 06/10] numa: " Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 07/10] tpm: " Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 08/10] vl: " Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 09/10] qemu-img: " Markus Armbruster
2015-02-12 13:34 ` [Qemu-devel] [PATCH v2 10/10] qemu-char: " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423748040-3448-5-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).