From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLtuF-0002rI-DM for qemu-devel@nongnu.org; Thu, 12 Feb 2015 08:34:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLtu8-0002TX-MO for qemu-devel@nongnu.org; Thu, 12 Feb 2015 08:34:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLtu8-0002TH-GD for qemu-devel@nongnu.org; Thu, 12 Feb 2015 08:34:04 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1CDY3GW004538 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 12 Feb 2015 08:34:03 -0500 Received: from blackfin.pond.sub.org (ovpn-116-32.ams2.redhat.com [10.36.116.32]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1CDY1sT020543 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 12 Feb 2015 08:34:02 -0500 From: Markus Armbruster Date: Thu, 12 Feb 2015 14:33:54 +0100 Message-Id: <1423748040-3448-5-git-send-email-armbru@redhat.com> In-Reply-To: <1423748040-3448-1-git-send-email-armbru@redhat.com> References: <1423748040-3448-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 04/10] monitor: Avoid qerror_report_err() outside QMP command handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in HMP command handler hmp_trace_event(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index ac2a4ab..b109188 100644 --- a/monitor.c +++ b/monitor.c @@ -889,8 +889,7 @@ static void do_trace_event_set_state(Monitor *mon, const QDict *qdict) qmp_trace_event_set_state(tp_name, new_state, true, true, &local_err); if (local_err) { - qerror_report_err(local_err); - error_free(local_err); + error_report_err(local_err); } } -- 1.9.3