From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLu9r-0001EY-5a for qemu-devel@nongnu.org; Thu, 12 Feb 2015 08:50:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLu9m-0007oH-So for qemu-devel@nongnu.org; Thu, 12 Feb 2015 08:50:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLu9m-0007oD-Lq for qemu-devel@nongnu.org; Thu, 12 Feb 2015 08:50:14 -0500 From: Markus Armbruster Date: Thu, 12 Feb 2015 14:49:50 +0100 Message-Id: <1423748990-9709-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, sheepdog@lists.wpkg.org, stefanha@redhat.com, kwolf@redhat.com If do_sd_create() fails, it first reports the error returned, then reports a another one with strerror(errno). errno is meaningless at that point. Report just one error combining the valid information from both messages. Reported-by: Eric Blake Signed-off-by: Markus Armbruster --- Applies on top of my "[PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err()", but rebasing to master would be trivial. block/sheepdog.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 6a4a3bd..0e8c712 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -2225,9 +2225,8 @@ static int sd_snapshot_create(BlockDriverState *bs, QEMUSnapshotInfo *sn_info) ret = do_sd_create(s, &new_vid, 1, &local_err); if (ret < 0) { - error_report_err(local_err); - error_report("failed to create inode for snapshot. %s", - strerror(errno)); + error_report("failed to create inode for snapshot: %s", + error_get_pretty(local_err)); goto cleanup; } -- 1.9.3