From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLxuh-0000x4-G6 for qemu-devel@nongnu.org; Thu, 12 Feb 2015 12:50:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLxug-0007Be-CU for qemu-devel@nongnu.org; Thu, 12 Feb 2015 12:50:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLxug-0007BP-5o for qemu-devel@nongnu.org; Thu, 12 Feb 2015 12:50:54 -0500 From: Eduardo Habkost Date: Thu, 12 Feb 2015 15:50:35 -0200 Message-Id: <1423763435-3696-5-git-send-email-ehabkost@redhat.com> In-Reply-To: <1423763435-3696-1-git-send-email-ehabkost@redhat.com> References: <1423763435-3696-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Igor Mammedov , Hu Tao , "Michael S. Tsirkin" Instead of silently assigning CPU to node 0 when it is omitted from the command-line, check if all CPUs up to max_cpus are present in the NUMA configuration. I am making this a warning and not a fatal error, to allow management software to be updated if necessary. Signed-off-by: Eduardo Habkost --- v1 -> v2: (no changes) v2 -> v3: * Use enumerate_cpus() and error_report() for error message * Simplify logic using bitmap_full() --- numa.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/numa.c b/numa.c index 712faff..4310bf9 100644 --- a/numa.c +++ b/numa.c @@ -201,6 +201,14 @@ static void validate_numa_cpus(void) bitmap_or(seen_cpus, seen_cpus, numa_info[i].node_cpu, MAX_CPUMASK_BITS); } + + if (!bitmap_full(seen_cpus, max_cpus)) { + char *msg; + bitmap_complement(seen_cpus, seen_cpus, max_cpus); + msg = enumerate_cpus(seen_cpus, max_cpus); + error_report("warning: CPU(s) not present in any NUMA nodes: %s", msg); + g_free(msg); + } } void parse_numa_opts(void) -- 2.1.0