qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	Michael Walle <michael@walle.cc>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names
Date: Fri, 13 Feb 2015 06:33:31 +0008	[thread overview]
Message-ID: <1423808731.4864.0@smtp.corp.redhat.com> (raw)
In-Reply-To: <1423738334-13545-1-git-send-email-armbru@redhat.com>



On Thu, Feb 12, 2015 at 6:52 PM, Markus Armbruster <armbru@redhat.com> 
wrote:
> When I can't guess a handler's name, I have to look it up in
> hmp-commands.hx.  Happens often enough to annoy me.  Let's make them
> more predictable.
> 
> Touches several subsystems because HMP command handlers are still
> spread far and wide, but the changes are trivial.  Speak up if you
> want your subsystem's part routed through your tree rather than
> -trivial.
> 
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Michael Walle <michael@walle.cc>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> 
> Markus Armbruster (3):
>   hmp: Clean up declarations for long-gone info handlers
>   hmp: Name HMP command handler functions hmp_COMMAND()
>   hmp: Name HMP info handler functions hmp_info_SUBCOMMAND()
> 
>  block/block-backend.c          |   6 +-
>  blockdev.c                     |   6 +-
>  device-hotplug.c               |   2 +-
>  hmp-commands.hx                |  86 +++++++++++++-------------
>  hmp.c                          |   6 +-
>  hmp.h                          |   6 +-
>  hw/core/loader.c               |   2 +-
>  hw/intc/i8259.c                |   4 +-
>  hw/intc/lm32_pic.c             |   4 +-
>  hw/pci/pci-hotplug-old.c       |   4 +-
>  hw/pci/pci-stub.c              |   2 +-
>  hw/pci/pcie_aer.c              |   2 +-
>  hw/sparc/sun4m.c               |   4 +-
>  hw/usb/bus.c                   |   2 +-
>  hw/usb/host-libusb.c           |   2 +-
>  hw/usb/host-stub.c             |   2 +-
>  include/hw/i386/pc.h           |   4 +-
>  include/hw/lm32/lm32_pic.h     |   4 +-
>  include/hw/loader.h            |   2 +-
>  include/hw/sparc/sun4m.h       |   4 +-
>  include/hw/usb.h               |   2 +-
>  include/migration/migration.h  |   4 --
>  include/monitor/qdev.h         |   4 +-
>  include/net/net.h              |   6 +-
>  include/net/slirp.h            |   6 +-
>  include/sysemu/block-backend.h |   2 +-
>  include/sysemu/blockdev.h      |   4 +-
>  include/sysemu/sysemu.h        |  23 +++----
>  include/ui/console.h           |   2 +-
>  include/ui/qemu-spice.h        |   3 -
>  monitor.c                      | 134 
> ++++++++++++++++++++---------------------
>  net/net.c                      |   6 +-
>  net/slirp.c                    |   6 +-
>  qdev-monitor.c                 |   4 +-
>  savevm.c                       |   6 +-
>  ui/input.c                     |   2 +-
>  vl.c                           |   4 +-
>  37 files changed, 181 insertions(+), 191 deletions(-)
> 
> -- 
> 1.9.3
> 

For net parts:

Acked-by: Jason Wang <jasowang@redhat.com>

      parent reply	other threads:[~2015-02-13  6:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 10:52 [Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names Markus Armbruster
2015-02-12 10:52 ` [Qemu-devel] [PATCH 1/3] hmp: Clean up declarations for long-gone info handlers Markus Armbruster
2015-02-12 10:52 ` [Qemu-devel] [PATCH 2/3] hmp: Name HMP command handler functions hmp_COMMAND() Markus Armbruster
2015-02-12 10:52 ` [Qemu-devel] [PATCH 3/3] hmp: Name HMP info handler functions hmp_info_SUBCOMMAND() Markus Armbruster
2015-02-12 11:09 ` [Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names Kevin Wolf
2015-02-13  6:25 ` Jason Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423808731.4864.0@smtp.corp.redhat.com \
    --to=jasowang@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael@walle.cc \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).